From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D2EC43387 for ; Wed, 16 Jan 2019 03:27:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D05820859 for ; Wed, 16 Jan 2019 03:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731243AbfAPD1v (ORCPT ); Tue, 15 Jan 2019 22:27:51 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:1511 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731019AbfAPD1v (ORCPT ); Tue, 15 Jan 2019 22:27:51 -0500 X-IronPort-AV: E=Sophos;i="5.56,484,1539619200"; d="scan'208";a="52109427" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 16 Jan 2019 11:27:49 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id 297EF4BAD9C3; Wed, 16 Jan 2019 11:27:47 +0800 (CST) Received: from localhost.localdomain (10.167.225.56) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 16 Jan 2019 11:27:53 +0800 Date: Wed, 16 Jan 2019 11:26:52 +0800 From: Chao Fan To: Borislav Petkov CC: , , , , , , , , , , Subject: Re: [PATCH v15 3/6] x86/boot: Introduce efi_get_rsdp_addr() to find RSDP from EFI table Message-ID: <20190116032652.GC30900@localhost.localdomain> References: <20190107032243.25324-4-fanc.fnst@cn.fujitsu.com> <20190110211523.GG17621@zn.tnic> <20190111012353.GD2216@localhost.localdomain> <20190111103225.GA4729@zn.tnic> <20190113094704.GC13263@localhost.localdomain> <20190113110544.GA7398@zn.tnic> <20190114012641.GA30900@localhost.localdomain> <20190114090756.GA2773@zn.tnic> <20190115072121.GB30900@localhost.localdomain> <20190115095502.GA6596@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190115095502.GA6596@zn.tnic> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [10.167.225.56] X-yoursite-MailScanner-ID: 297EF4BAD9C3.AEB44 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: fanc.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 10:55:02AM +0100, Borislav Petkov wrote: >On Tue, Jan 15, 2019 at 03:21:21PM +0800, Chao Fan wrote: >> In my understanding after looking into the commit message the comments. >> I thinks yes. For 32-bit OS: > >And when does your "32-bit OS" define ACPI_ASL_COMPILER ? Ah, I got it. You are right. Linux will never define this tag. It's only used by other tools. I misunderstood include/acpi/platform/acenv.h I learn much about Kernel compilation. Thanks for that. I will change as you suggested. Thanks, Chao Fan > >-- >Regards/Gruss, > Boris. > >Good mailing practices for 400: avoid top-posting and trim the reply. > >