Re: [RESENDING PATCH] powerpc/wii: properly disable use of BATs when requested.

Jonathan Neuschäfer
2019-01-17T01:05:25Z

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

Hi again,

On Tue, Jan 15, 2019 at 04:43:20PM +0000, Christophe Leroy wrote:
> 'nobats' kernel parameter or some options like CONFIG_DEBUG_PAGEALLOC
> deny the use of BATS for mapping memory.
>
> This patch makes sure that the specific wii RAM mapping function
> takes it into account as well.
>
> Fixes: de32400dd26e ("wii: use both mem1 and mem2 as ram")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
[...]
> /* MEM2 64MB@0x10000000 */
> delta = wii_hole_start + wii_hole_size;
> + if (__map_without_bats)
> + return delta;
> +

Nothing is visibly broken without this patch, even with
CONFIG_DEBUG_PAGEALLOC (tested on top of v5.0-rc2), but the patch still
looks correct.

I'd prefer the 'if' block to be before the whole delta/size calculation,
to make the code slightly more readable because the delta and size
calculations stay in one visual block. It doesn't need to happen after
delta is calculated.

tentatively,
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Thanks,
Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]