From: Stefan Agner <stefan@agner.ch>
To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com
Cc: fabio.estevam@nxp.com, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, Stefan Agner <stefan@agner.ch>
Subject: [PATCH 4/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails
Date: Thu, 17 Jan 2019 10:06:39 +0100 [thread overview]
Message-ID: <20190117090640.12972-4-stefan@agner.ch> (raw)
In-Reply-To: <20190117090640.12972-1-stefan@agner.ch>
Make sure to properly put the of node in case finding the codec
fails.
Fixes: 81e8e4926167 ("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000")
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
sound/soc/fsl/imx-sgtl5000.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
index e1e20499b2f1..45969e6dfad7 100644
--- a/sound/soc/fsl/imx-sgtl5000.c
+++ b/sound/soc/fsl/imx-sgtl5000.c
@@ -111,7 +111,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
codec_dev = of_find_i2c_device_by_node(codec_np);
if (!codec_dev) {
dev_err(&pdev->dev, "failed to find codec platform device\n");
- return -EPROBE_DEFER;
+ ret = -EPROBE_DEFER;
+ goto fail;
}
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
--
2.20.1
next prev parent reply other threads:[~2019-01-17 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:06 [PATCH 1/5] ASoC: fsl_spdif: don't print EPROBE_DEFER as error Stefan Agner
2019-01-17 9:06 ` [PATCH 2/5] ASoC: imx-spdif: " Stefan Agner
2019-01-17 9:59 ` [alsa-devel] " Daniel Baluta
2019-01-17 22:00 ` Nicolin Chen
2019-01-17 9:06 ` [PATCH 3/5] ASoC: imx-sgtl5000: " Stefan Agner
2019-01-17 10:01 ` [alsa-devel] " Daniel Baluta
2019-01-17 22:03 ` Nicolin Chen
2019-01-17 9:06 ` Stefan Agner [this message]
2019-01-17 10:04 ` [alsa-devel] [PATCH 4/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails Daniel Baluta
2019-01-17 12:04 ` Fabio Estevam
2019-01-17 22:04 ` Nicolin Chen
2019-01-17 9:06 ` [PATCH 5/5] ASoC: imx-sgtl5000: lower log level for potential probe deferral cases Stefan Agner
2019-01-17 10:00 ` [alsa-devel] " Daniel Baluta
2019-01-17 22:01 ` Nicolin Chen
2019-01-17 10:01 ` [alsa-devel] [PATCH 1/5] ASoC: fsl_spdif: don't print EPROBE_DEFER as error Daniel Baluta
2019-01-17 21:52 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117090640.12972-4-stefan@agner.ch \
--to=stefan@agner.ch \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox