* [PATCH] dma-buf: Fix kerneldoc comment for struct dma_fence_array
@ 2019-01-16 22:34 Jonathan Corbet
2019-01-17 9:13 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Corbet @ 2019-01-16 22:34 UTC (permalink / raw)
To: Sumit Semwal; +Cc: dri-devel, LKML
The kerneldoc comment for struct dma_fence_array lacks a description
of the "work" member, leading to this docs-build warning:
./include/linux/dma-fence-array.h:54: warning: Function parameter or member 'work' not described in 'dma_fence_array'
Add a description and make the warning go away.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
---
Hopefully I've sent this to the right place; perhaps this file needs to be
added to the MAINTAINERS entry?
include/linux/dma-fence-array.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/dma-fence-array.h b/include/linux/dma-fence-array.h
index bc8940ca280d..c0ff417b4770 100644
--- a/include/linux/dma-fence-array.h
+++ b/include/linux/dma-fence-array.h
@@ -40,6 +40,7 @@ struct dma_fence_array_cb {
* @num_fences: number of fences in the array
* @num_pending: fences in the array still pending
* @fences: array of the fences
+ * @work: internal irq_work function
*/
struct dma_fence_array {
struct dma_fence base;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dma-buf: Fix kerneldoc comment for struct dma_fence_array
2019-01-16 22:34 [PATCH] dma-buf: Fix kerneldoc comment for struct dma_fence_array Jonathan Corbet
@ 2019-01-17 9:13 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2019-01-17 9:13 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: Sumit Semwal, LKML, dri-devel
On Wed, Jan 16, 2019 at 03:34:36PM -0700, Jonathan Corbet wrote:
> The kerneldoc comment for struct dma_fence_array lacks a description
> of the "work" member, leading to this docs-build warning:
>
> ./include/linux/dma-fence-array.h:54: warning: Function parameter or member 'work' not described in 'dma_fence_array'
>
> Add a description and make the warning go away.
>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Applied for 5.1, thanks for your patch.
-Daniel
> ---
> Hopefully I've sent this to the right place; perhaps this file needs to be
> added to the MAINTAINERS entry?
>
> include/linux/dma-fence-array.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/dma-fence-array.h b/include/linux/dma-fence-array.h
> index bc8940ca280d..c0ff417b4770 100644
> --- a/include/linux/dma-fence-array.h
> +++ b/include/linux/dma-fence-array.h
> @@ -40,6 +40,7 @@ struct dma_fence_array_cb {
> * @num_fences: number of fences in the array
> * @num_pending: fences in the array still pending
> * @fences: array of the fences
> + * @work: internal irq_work function
> */
> struct dma_fence_array {
> struct dma_fence base;
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-17 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-16 22:34 [PATCH] dma-buf: Fix kerneldoc comment for struct dma_fence_array Jonathan Corbet
2019-01-17 9:13 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox