From: Jiri Olsa <jolsa@redhat.com>
To: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py
Date: Thu, 17 Jan 2019 13:32:02 +0100 [thread overview]
Message-ID: <20190117123202.GC16366@krava> (raw)
In-Reply-To: <1547718344-27382-1-git-send-email-s1seetee@linux.vnet.ibm.com>
On Thu, Jan 17, 2019 at 03:15:28PM +0530, Seeteena Thoufeek wrote:
> Support both Python 2 and Python 3 in check-perf-trace.py.
> ``print`` is now a function rather than a statement. This should have
> no functional change.
>
> Fix indentation issue, replace spaces with tab
>
> Signed-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
> Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
hum, could you please add some info about testing those changes?
(or even some global into 0/.. patch)
this is working for me on python2:
[root@krava perf]# perf script rec check-perf-trace
^C
[root@krava perf]# perf script -s scripts/python/check-perf-trace.py
trace_begin
unhandled events:
event count
---------------------------------------- -----------
raw_syscalls__sys_enter 3509879
but fails for python3:
[root@ibm-x3650m4-01-vm-04 perf]# perf script rec check-perf-trace
^C[ perf record: Woken up 0 times to write data ]
Warning:
1 out of order events recorded.
[ perf record: Captured and wrote 43.132 MB perf.data (490171 samples) ]
[root@ibm-x3650m4-01-vm-04 perf]# perf script -s scripts/python/check-perf-trace.py
Traceback (most recent call last):
File "scripts/python/check-perf-trace.py", line 18, in <module>
from perf_trace_context import *
ModuleNotFoundError: No module named 'perf_trace_context'
Error running python script scripts/python/check-perf-trace.py
I did not test with rpm, just did 'make install' for perf
thanks,
jirka
next prev parent reply other threads:[~2019-01-17 12:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:45 [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py Seeteena Thoufeek
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to event_analyzing_sample.py Seeteena Thoufeek
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to exported-sql-viewer.py Seeteena Thoufeek
2019-01-19 0:45 ` Tony Jones
2019-01-20 19:27 ` Jonathan Corbet
2019-01-20 20:50 ` Tony Jones
2019-01-21 10:45 ` seeteena
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to export-to-sqlite.py Seeteena Thoufeek
2019-01-19 1:05 ` Tony Jones
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to failed-syscalls-by-pid.py Seeteena Thoufeek
2019-01-19 1:12 ` Tony Jones
2019-01-19 2:37 ` Tony Jones
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to futex-contention.py Seeteena Thoufeek
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to intel-pt-events.py Seeteena Thoufeek
2019-01-19 1:16 ` Tony Jones
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to mem-phys-addr.py Seeteena Thoufeek
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to netdev-times.py Seeteena Thoufeek
2019-01-19 1:21 ` Tony Jones
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to net_dropmonitor.py Seeteena Thoufeek
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to powerpc-hcalls.py Seeteena Thoufeek
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to sctop.py Seeteena Thoufeek
2019-01-19 1:27 ` Tony Jones
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to stackcollapse.py Seeteena Thoufeek
2019-01-19 1:46 ` Tony Jones
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to stat-cpi.py Seeteena Thoufeek
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to syscall-counts-by-pid.py Seeteena Thoufeek
2019-01-19 0:53 ` Tony Jones
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to syscall-counts.py Seeteena Thoufeek
2019-01-17 9:45 ` [PATCH v2] perf scripts python: Add Python 3 support to export-to-postgresql.py Seeteena Thoufeek
2019-01-17 12:32 ` Jiri Olsa [this message]
2019-01-17 13:23 ` [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py Ravi Bangoria
2019-01-19 0:29 ` Tony Jones
2019-01-19 2:05 ` Tony Jones
2019-01-19 0:59 ` Tony Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117123202.GC16366@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=s1seetee@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox