From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DAB1C43387 for ; Thu, 17 Jan 2019 19:47:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2136C20855 for ; Thu, 17 Jan 2019 19:47:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728924AbfAQTr3 (ORCPT ); Thu, 17 Jan 2019 14:47:29 -0500 Received: from mga14.intel.com ([192.55.52.115]:64907 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728776AbfAQTr2 (ORCPT ); Thu, 17 Jan 2019 14:47:28 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 11:47:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,489,1539673200"; d="scan'208";a="135546499" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga002.fm.intel.com with SMTP; 17 Jan 2019 11:47:23 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 17 Jan 2019 21:47:22 +0200 Date: Thu, 17 Jan 2019 21:47:22 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Christoph Manszewski Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Seung-Woo Kim , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , David Airlie , Kyungmin Park , Kukjin Kim , Sean Paul , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Subject: Re: [PATCH 1/6] include/drm: color_mgmt: Add enum labels Message-ID: <20190117194722.GJ20097@intel.com> References: <1544789421-5265-1-git-send-email-c.manszewski@samsung.com> <1544789421-5265-2-git-send-email-c.manszewski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1544789421-5265-2-git-send-email-c.manszewski@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 14, 2018 at 01:10:16PM +0100, Christoph Manszewski wrote: > Range setting makes sense for YCbCr and RGB buffers. Current > drm_color_range enum labels suggest use with YCbCr buffers. > Create enum labels without colorspace specification. > > Signed-off-by: Christoph Manszewski > --- > include/drm/drm_color_mgmt.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h > index 90ef9996d9a4..52f6d5221a0d 100644 > --- a/include/drm/drm_color_mgmt.h > +++ b/include/drm/drm_color_mgmt.h > @@ -62,6 +62,8 @@ enum drm_color_range { > DRM_COLOR_YCBCR_LIMITED_RANGE, > DRM_COLOR_YCBCR_FULL_RANGE, > DRM_COLOR_RANGE_MAX, > + DRM_COLOR_LIMITED_RANGE = DRM_COLOR_YCBCR_LIMITED_RANGE, > + DRM_COLOR_FULL_RANGE = DRM_COLOR_YCBCR_FULL_RANGE, These enum values don't mean anything really. The strings are what matter for the uapi. The default for YCbCr needs to be limited range, the default for RGB needs to be full range. So I think this would really require a separate prop for each. But is there an actual usecase for this stuff? > }; > > int drm_plane_create_color_properties(struct drm_plane *plane, > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel