From: Guenter Roeck <linux@roeck-us.net>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: (ina3221) Implement ti,single-shot DT property
Date: Thu, 17 Jan 2019 14:58:42 -0800 [thread overview]
Message-ID: <20190117225842.GA23511@roeck-us.net> (raw)
In-Reply-To: <20190117223012.GH16918@Asurada-Nvidia.nvidia.com>
On Thu, Jan 17, 2019 at 02:30:13PM -0800, Nicolin Chen wrote:
> On Mon, Jan 07, 2019 at 11:35:55AM -0800, Guenter Roeck wrote:
>
> > > + if (of_property_read_bool(np, "ti,single-shot"))
> > > + ina->single_shot = true;
> > > +
> > ina->single_shot = of_property_read_bool(np, "ti,single-shot");
> >
> > No need to resend right now; let's wait for feedback from Rob.
>
> Looks like Rob has acked. Is this resend version fine for review?
>
"Right now" was supposed to mean that you should wait for Rob's
feedback before sending v3 with the feedback above applied.
Did you send that version ? I don't see it in patchwork, nor
in my inbox.
Thanks,
Guenter
next prev parent reply other threads:[~2019-01-17 22:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 3:06 [PATCH v2 0/2] hwmon (ina3221) Add single-shot mode support Nicolin Chen
2019-01-05 3:06 ` [PATCH v2 1/2] dt-bindings: hwmon: ina3221: Add ti,single-shot property Nicolin Chen
2019-01-11 21:34 ` Rob Herring
2019-01-05 3:06 ` [PATCH v2 2/2] hwmon: (ina3221) Implement ti,single-shot DT property Nicolin Chen
2019-01-07 19:35 ` Guenter Roeck
2019-01-17 22:30 ` Nicolin Chen
2019-01-17 22:58 ` Guenter Roeck [this message]
2019-01-17 23:02 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117225842.GA23511@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox