[PATCH] USB: EHCI: ehci-mv: add MODULE_DEVICE_TABLE

[PATCH] USB: EHCI: ehci-mv: add MODULE_DEVICE_TABLE

[Lubomir Rintel]

This fixes autoloading the module by the OF compatible string.

Fixes: 813e18b18a87f31c5b216ea7546127deac3ae1ae
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 drivers/usb/host/ehci-mv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index f26109eafdbf..66ec1fdf9fe7 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -302,3 +302,4 @@ MODULE_AUTHOR("Chao Xie <chao.xie@marvell.com>");
 MODULE_AUTHOR("Neil Zhang <zhangwm@marvell.com>");
 MODULE_ALIAS("mv-ehci");
 MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(of, ehci_mv_dt_ids);
-- 
2.19.2

Re: [PATCH] USB: EHCI: ehci-mv: add MODULE_DEVICE_TABLE

[Greg Kroah-Hartman]

On Mon, Jan 14, 2019 at 09:16:08PM +0100, Lubomir Rintel wrote:
> This fixes autoloading the module by the OF compatible string.
> 
> Fixes: 813e18b18a87f31c5b216ea7546127deac3ae1ae

In the future, this type of line should be written as:
Fixes: 813e18b18a87 ("USB: EHCI: ehci-mv: add DT support")

I'll change this in the patch, but next time be more careful.

thanks,

greg k-h

Re: [PATCH] USB: EHCI: ehci-mv: add MODULE_DEVICE_TABLE

[Greg Kroah-Hartman]

On Mon, Jan 14, 2019 at 09:16:08PM +0100, Lubomir Rintel wrote:
> This fixes autoloading the module by the OF compatible string.
> 
> Fixes: 813e18b18a87 ("USB: EHCI: ehci-mv: add DT support")
> Cc: stable@vger.kernel.org # v4.19+

Wait, why 4.19?  813e18b18a87 is in 4.20, not 4.19, so why would this
matter to 4.19 at all?

thanks,

greg k-h

Re: [PATCH] USB: EHCI: ehci-mv: add MODULE_DEVICE_TABLE

[Lubomir Rintel]

On Fri, 2019-01-18 at 09:52 +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 14, 2019 at 09:16:08PM +0100, Lubomir Rintel wrote:
> > This fixes autoloading the module by the OF compatible string.
> > 
> > Fixes: 813e18b18a87 ("USB: EHCI: ehci-mv: add DT support")
> > Cc: stable@vger.kernel.org # v4.19+
> 
> Wait, why 4.19?  813e18b18a87 is in 4.20, not 4.19, so why would this
> matter to 4.19 at all?

You're right.

Sorry. (I've naively used "git describe 813e18b18a87" to guess the
release this went to, failing to realize that the commit went to main
tree via merge. I guess I should've done a git tag --contains instead.)

> 
> thanks,
> 
> greg k-h

Lubo

Re: [PATCH] USB: EHCI: ehci-mv: add MODULE_DEVICE_TABLE

[Greg Kroah-Hartman]

On Fri, Jan 18, 2019 at 09:56:53AM +0100, Lubomir Rintel wrote:
> On Fri, 2019-01-18 at 09:52 +0100, Greg Kroah-Hartman wrote:
> > On Mon, Jan 14, 2019 at 09:16:08PM +0100, Lubomir Rintel wrote:
> > > This fixes autoloading the module by the OF compatible string.
> > > 
> > > Fixes: 813e18b18a87 ("USB: EHCI: ehci-mv: add DT support")
> > > Cc: stable@vger.kernel.org # v4.19+
> > 
> > Wait, why 4.19?  813e18b18a87 is in 4.20, not 4.19, so why would this
> > matter to 4.19 at all?
> 
> You're right.
> 
> Sorry. (I've naively used "git describe 813e18b18a87" to guess the
> release this went to, failing to realize that the commit went to main
> tree via merge. I guess I should've done a git tag --contains instead.)

Thanks for verifying, I'll fix that up too.

thanks,

greg k-h