Re: [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code

Sam Ravnborg
2019-01-25T18:10:16Z

Hi Noralf.

> > Lovely diffstat, thanks to the new generic fbdev emulation.
> >
> > drm/qxl/Makefile | 2
> > drm/qxl/qxl_draw.c | 232 ----------------------------------------
> > drm/qxl/qxl_drv.h | 21 ---
> > drm/qxl/qxl_fb.c | 300 -----------------------------------------------------
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > drivers/gpu/drm/qxl/qxl_drv.h | 21 ---
> > drivers/gpu/drm/qxl/qxl_draw.c | 232 -------------------------------
> > drivers/gpu/drm/qxl/qxl_fb.c | 300 -----------------------------------------
> > drivers/gpu/drm/qxl/Makefile | 2 +-
> > 4 files changed, 1 insertion(+), 554 deletions(-)
> > delete mode 100644 drivers/gpu/drm/qxl/qxl_fb.c
> >
>
> Nice!
>
> Acked-by: Noralf Trønnes <noralf@tronnes.org>
It must be a very satisfying experience to see such benefits
of the many hours of works you have put into the genric
fbdev emulation code.
Well done, and indeed a nice patch from Gerd.

Sam