From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jann Horn <jannh@google.com>
Cc: Jiri Slaby <jslaby@suse.com>, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] tiocsti() NULL dereference if ld->ops->receive_buf==NULL
Date: Sat, 19 Jan 2019 10:11:08 +0100 [thread overview]
Message-ID: <20190119091108.GF10836@kroah.com> (raw)
In-Reply-To: <CAG48ez06mDExELyTYN7MZQ3FjGcLx9ASc5HnxW8NQbfTAPX=Qg@mail.gmail.com>
On Fri, Jan 18, 2019 at 08:09:07PM +0100, Jann Horn wrote:
> Hi!
>
> When a line discipline doesn't have a ->receive_buf handler, tiocsti()
> attempts to call a NULL pointer. Both tty_n_tracesink and
> spk_ttyio_ldisc_ops don't have such a handler.
>
> To reproduce, build a kernel with CONFIG_SPEAKUP=y and
> CONFIG_SPEAKUP_SYNTH_SOFT=y, set speakup.synth=soft in the kernel
> command line, and run the following code as root:
<snip>
Ugh, thanks for finding this. I'll look at it later this afternoon...
greg k-h
next prev parent reply other threads:[~2019-01-19 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 19:09 [BUG] tiocsti() NULL dereference if ld->ops->receive_buf==NULL Jann Horn
2019-01-19 9:11 ` Greg Kroah-Hartman [this message]
2019-01-20 9:52 ` Greg Kroah-Hartman
2019-01-21 15:38 ` Jann Horn
2019-01-21 16:14 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119091108.GF10836@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox