From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFCBC282DE for ; Mon, 21 Jan 2019 07:41:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F3AB20989 for ; Mon, 21 Jan 2019 07:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728741AbfAUHln (ORCPT ); Mon, 21 Jan 2019 02:41:43 -0500 Received: from mga14.intel.com ([192.55.52.115]:22809 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728037AbfAUHlm (ORCPT ); Mon, 21 Jan 2019 02:41:42 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2019 16:19:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,501,1539673200"; d="scan'208";a="139899897" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.37]) by fmsmga001.fm.intel.com with ESMTP; 20 Jan 2019 16:19:43 -0800 Date: Mon, 21 Jan 2019 08:19:20 +0800 From: Wei Yang To: "Rafael J. Wysocki" Cc: Wei Yang , Linux Kernel Mailing List , Greg Kroah-Hartman Subject: Re: [PATCH v2] driver core: move device->knode_class to device_private Message-ID: <20190121001920.GA3680@richard> Reply-To: Wei Yang References: <20190117055719.6161-1-richardw.yang@linux.intel.com> <20190118023459.9972-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 18, 2019 at 11:06:23AM +0100, Rafael J. Wysocki wrote: >On Fri, Jan 18, 2019 at 3:35 AM Wei Yang wrote: >> >> As the description of struct device_private says, it stores data which >> is private to driver core. And it already has similar fields like: >> knode_parent, knode_driver, knode_driver and knode_bus. This look it is >> more proper to put knode_class together with those fields to make it >> private to driver core. >> >> This patch move device->knode_class to device_private to make it comply >> with code convention. >> >> Signed-off-by: Wei Yang >> >> --- >> v2: add a helper to get dev from klist_class > >Looks better now. > >Reviewed-by: Rafael J. Wysocki Thanks :-) > >> --- >> drivers/base/base.h | 4 ++++ >> drivers/base/class.c | 14 ++++++++++---- >> drivers/base/core.c | 4 ++-- >> include/linux/device.h | 1 - >> 4 files changed, 16 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/base/base.h b/drivers/base/base.h >> index 7a419a7a6235..37329a668935 100644 >> --- a/drivers/base/base.h >> +++ b/drivers/base/base.h >> @@ -60,6 +60,7 @@ struct driver_private { >> * @knode_parent - node in sibling list >> * @knode_driver - node in driver list >> * @knode_bus - node in bus list >> + * @knode_class - node in class list >> * @deferred_probe - entry in deferred_probe_list which is used to retry the >> * binding of drivers which were unable to get all the resources needed by >> * the device; typically because it depends on another driver getting >> @@ -74,6 +75,7 @@ struct device_private { >> struct klist_node knode_parent; >> struct klist_node knode_driver; >> struct klist_node knode_bus; >> + struct klist_node knode_class; >> struct list_head deferred_probe; >> struct device *device; >> }; >> @@ -83,6 +85,8 @@ struct device_private { >> container_of(obj, struct device_private, knode_driver) >> #define to_device_private_bus(obj) \ >> container_of(obj, struct device_private, knode_bus) >> +#define to_device_private_class(obj) \ >> + container_of(obj, struct device_private, knode_class) >> >> /* initialisation functions */ >> extern int devices_init(void); >> diff --git a/drivers/base/class.c b/drivers/base/class.c >> index 54def4e02f00..d8a6a5864c2e 100644 >> --- a/drivers/base/class.c >> +++ b/drivers/base/class.c >> @@ -117,16 +117,22 @@ static void class_put(struct class *cls) >> kset_put(&cls->p->subsys); >> } >> >> +static struct device *klist_class_to_dev(struct klist_node *n) >> +{ >> + struct device_private *p = to_device_private_class(n); >> + return p->device; >> +} >> + >> static void klist_class_dev_get(struct klist_node *n) >> { >> - struct device *dev = container_of(n, struct device, knode_class); >> + struct device *dev = klist_class_to_dev(n); >> >> get_device(dev); >> } >> >> static void klist_class_dev_put(struct klist_node *n) >> { >> - struct device *dev = container_of(n, struct device, knode_class); >> + struct device *dev = klist_class_to_dev(n); >> >> put_device(dev); >> } >> @@ -277,7 +283,7 @@ void class_dev_iter_init(struct class_dev_iter *iter, struct class *class, >> struct klist_node *start_knode = NULL; >> >> if (start) >> - start_knode = &start->knode_class; >> + start_knode = &start->p->knode_class; >> klist_iter_init_node(&class->p->klist_devices, &iter->ki, start_knode); >> iter->type = type; >> } >> @@ -304,7 +310,7 @@ struct device *class_dev_iter_next(struct class_dev_iter *iter) >> knode = klist_next(&iter->ki); >> if (!knode) >> return NULL; >> - dev = container_of(knode, struct device, knode_class); >> + dev = klist_class_to_dev(knode); >> if (!iter->type || iter->type == dev->type) >> return dev; >> } >> diff --git a/drivers/base/core.c b/drivers/base/core.c >> index 04bbcd779e11..a624d27d11c0 100644 >> --- a/drivers/base/core.c >> +++ b/drivers/base/core.c >> @@ -1932,7 +1932,7 @@ int device_add(struct device *dev) >> if (dev->class) { >> mutex_lock(&dev->class->p->mutex); >> /* tie the class to the device */ >> - klist_add_tail(&dev->knode_class, >> + klist_add_tail(&dev->p->knode_class, >> &dev->class->p->klist_devices); >> >> /* notify any interfaces that the device is here */ >> @@ -2069,7 +2069,7 @@ void device_del(struct device *dev) >> if (class_intf->remove_dev) >> class_intf->remove_dev(dev, class_intf); >> /* remove the device from the class list */ >> - klist_del(&dev->knode_class); >> + klist_del(&dev->p->knode_class); >> mutex_unlock(&dev->class->p->mutex); >> } >> device_remove_file(dev, &dev_attr_uevent); >> diff --git a/include/linux/device.h b/include/linux/device.h >> index 1b25c7a43f4c..040e97669f94 100644 >> --- a/include/linux/device.h >> +++ b/include/linux/device.h >> @@ -1035,7 +1035,6 @@ struct device { >> spinlock_t devres_lock; >> struct list_head devres_head; >> >> - struct klist_node knode_class; >> struct class *class; >> const struct attribute_group **groups; /* optional groups */ >> >> -- >> 2.19.1 >> -- Wei Yang Help you, Help me