From: Wei Yang <richardw.yang@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org
Subject: Re: [PATCH v2] driver core: move device->knode_class to device_private
Date: Mon, 21 Jan 2019 08:35:56 +0800 [thread overview]
Message-ID: <20190121003556.GA4544@richard> (raw)
In-Reply-To: <20190118155541.GA5544@kroah.com>
On Fri, Jan 18, 2019 at 04:55:41PM +0100, Greg KH wrote:
>On Fri, Jan 18, 2019 at 10:34:59AM +0800, Wei Yang wrote:
>> As the description of struct device_private says, it stores data which
>> is private to driver core. And it already has similar fields like:
>> knode_parent, knode_driver, knode_driver and knode_bus. This look it is
>> more proper to put knode_class together with those fields to make it
>> private to driver core.
>>
>> This patch move device->knode_class to device_private to make it comply
>> with code convention.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
>Thanks for this. There are a number of other variables that should move
>into this structure, if you want to take a look into doing that.
Really? I may not notice that yet.
I may try to take a look into this, but not sure I would have enough time :-)
>
>greg k-h
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2019-01-21 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 5:57 [PATCH] driver core: move device->knode_class to device_private Wei Yang
2019-01-17 9:38 ` Rafael J. Wysocki
2019-01-18 1:39 ` Wei Yang
2019-01-18 2:34 ` [PATCH v2] " Wei Yang
2019-01-18 10:06 ` Rafael J. Wysocki
2019-01-21 0:19 ` Wei Yang
2019-01-18 15:55 ` Greg KH
2019-01-21 0:35 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121003556.GA4544@richard \
--to=richardw.yang@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox