From: Christoph Hellwig <hch@lst.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
linux-input@vger.kernel.org, Even Xu <even.xu@intel.com>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v1] HID: intel-ish-hid: Switch to use new generic UUID API
Date: Mon, 21 Jan 2019 09:40:08 +0100 [thread overview]
Message-ID: <20190121084008.GA18680@lst.de> (raw)
In-Reply-To: <20190110154804.89298-1-andriy.shevchenko@linux.intel.com>
On Thu, Jan 10, 2019 at 05:48:04PM +0200, Andy Shevchenko wrote:
> There are new types and helpers that are supposed to be used in new code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 3 +--
> drivers/hid/intel-ish-hid/ishtp-hid.h | 6 +++---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 19 ++++++++-----------
> drivers/hid/intel-ish-hid/ishtp/bus.h | 4 ++--
> drivers/hid/intel-ish-hid/ishtp/client.h | 2 +-
> drivers/hid/intel-ish-hid/ishtp/hbm.h | 2 +-
> 6 files changed, 16 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c
> index e64243bc9c96..2246697ada1d 100644
> --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c
> +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c
> @@ -788,8 +788,7 @@ static int hid_ishtp_cl_probe(struct ishtp_cl_device *cl_device)
> if (!cl_device)
> return -ENODEV;
>
> - if (uuid_le_cmp(hid_ishtp_guid,
> - cl_device->fw_client->props.protocol_name) != 0)
> + if (!guid_equal(&hid_ishtp_guid, &cl_device->fw_client->props.protocol_name))
This adds an overly long line.
With that fixed:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-01-21 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 15:48 [PATCH v1] HID: intel-ish-hid: Switch to use new generic UUID API Andy Shevchenko
2019-01-21 8:40 ` Christoph Hellwig [this message]
2019-01-22 17:29 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121084008.GA18680@lst.de \
--to=hch@lst.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=even.xu@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox