public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
	Brian Starkey <Brian.Starkey@arm.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: drm/komeda: Remove unused variable
Date: Mon, 21 Jan 2019 08:40:37 +0000	[thread overview]
Message-ID: <20190121084022.GA20856@james-ThinkStation-P300> (raw)
In-Reply-To: <20190118214018.GA24089@embeddedor>

Hi Gustavo:

Thank you for helping fix this problem


On Fri, Jan 18, 2019 at 03:40:18PM -0600, Gustavo A. R. Silva wrote:
> Remove unused variable *pdev* in komeda_parse_dt():
>
> drivers/gpu/drm/arm/display/komeda//komeda_dev.c: In function ‘komeda_parse_dt’:
> drivers/gpu/drm/arm/display/komeda//komeda_dev.c:52:26: warning: unused variable ‘pdev’ [-Wunused-variable]
>   struct platform_device *pdev = to_platform_device(dev);
>                           ^~~~
>
> Fixes: 7e8d4fcf8daf ("drm: arm/komeda: Remove IRQ parsing from initial series")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 16f4e72abc1a..0fe6954fbbf4 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -49,7 +49,6 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
>
>  static int komeda_parse_dt(struct device *dev, struct komeda_dev *mdev)
>  {
> -struct platform_device *pdev = to_platform_device(dev);
>  struct device_node *child, *np = dev->of_node;
>  struct clk *clk;
>  int ret;
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

      reply	other threads:[~2019-01-21  8:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 21:40 [PATCH] drm/komeda: Remove unused variable Gustavo A. R. Silva
2019-01-21  8:40 ` james qian wang (Arm Technology China) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190121084022.GA20856@james-ThinkStation-P300 \
    --to=james.qian.wang@arm.com \
    --cc=Brian.Starkey@arm.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox