From: Boris Brezillon <bbrezillon@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mtd@lists.infradead.org,
Boris Brezillon <boris.brezillon@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: rawnand: denali: remove ->erase hook
Date: Mon, 21 Jan 2019 09:10:13 +0100 [thread overview]
Message-ID: <20190121091013.4a6f55a2@bbrezillon> (raw)
In-Reply-To: <1548046326-26776-1-git-send-email-yamada.masahiro@socionext.com>
On Mon, 21 Jan 2019 13:52:06 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> Commit f9ebd1bb4103 ("mtd: rawnand: Deprecate ->erase()") discouraged
> the use of this hook, so I am happy to follow the suggestion.
>
> Although the Denali IP provides a special MAP10 command for erasing,
> using it would not buy us much. The Denali IP actually works with the
> generic erasing by single_erase() + ->cmdfunc hook (nand_command_lp)
> + ->cmd_ctrl hook (denali_cmd_ctrl).
>
> This method is also deprecated, but denali_erase() can go away
> irrespective of ->exec_op conversion.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
> ---
>
> drivers/mtd/nand/raw/denali.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c
> index 6e8edc9..21320b1 100644
> --- a/drivers/mtd/nand/raw/denali.c
> +++ b/drivers/mtd/nand/raw/denali.c
> @@ -37,9 +37,6 @@
> #define DENALI_MAP11_ADDR ((DENALI_MAP11) | 1) /* address cycle */
> #define DENALI_MAP11_DATA ((DENALI_MAP11) | 2) /* data cycle */
>
> -/* MAP10 commands */
> -#define DENALI_ERASE 0x01
> -
> #define DENALI_BANK(denali) ((denali)->active_bank << 24)
>
> #define DENALI_INVALID_BANK -1
> @@ -903,23 +900,6 @@ static int denali_waitfunc(struct nand_chip *chip)
> return irq_status & INTR__INT_ACT ? 0 : NAND_STATUS_FAIL;
> }
>
> -static int denali_erase(struct nand_chip *chip, int page)
> -{
> - struct denali_nand_info *denali = mtd_to_denali(nand_to_mtd(chip));
> - uint32_t irq_status;
> -
> - denali_reset_irq(denali);
> -
> - denali->host_write(denali, DENALI_MAP10 | DENALI_BANK(denali) | page,
> - DENALI_ERASE);
> -
> - /* wait for erase to complete or failure to occur */
> - irq_status = denali_wait_for_irq(denali,
> - INTR__ERASE_COMP | INTR__ERASE_FAIL);
> -
> - return irq_status & INTR__ERASE_COMP ? 0 : -EIO;
> -}
> -
> static int denali_setup_data_interface(struct nand_chip *chip, int chipnr,
> const struct nand_data_interface *conf)
> {
> @@ -1244,7 +1224,6 @@ static int denali_attach_chip(struct nand_chip *chip)
> chip->ecc.write_page_raw = denali_write_page_raw;
> chip->ecc.read_oob = denali_read_oob;
> chip->ecc.write_oob = denali_write_oob;
> - chip->legacy.erase = denali_erase;
>
> ret = denali_multidev_fixup(denali);
> if (ret)
next prev parent reply other threads:[~2019-01-21 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 4:52 [PATCH] mtd: rawnand: denali: remove ->erase hook Masahiro Yamada
2019-01-21 8:10 ` Boris Brezillon [this message]
2019-01-25 12:36 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121091013.4a6f55a2@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox