From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9607BC282F6 for ; Mon, 21 Jan 2019 09:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D5512085A for ; Mon, 21 Jan 2019 09:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728261AbfAUJnX (ORCPT ); Mon, 21 Jan 2019 04:43:23 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:46261 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726872AbfAUJnX (ORCPT ); Mon, 21 Jan 2019 04:43:23 -0500 X-IronPort-AV: E=Sophos;i="5.56,502,1539619200"; d="scan'208";a="52487551" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 21 Jan 2019 17:43:20 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id B585A4C47E9E; Mon, 21 Jan 2019 17:43:19 +0800 (CST) Received: from localhost.localdomain (10.167.225.56) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 21 Jan 2019 17:43:24 +0800 Date: Mon, 21 Jan 2019 17:42:14 +0800 From: Chao Fan To: Borislav Petkov CC: , , , , , , , , , Subject: Re: [PATCH v15 5/6] x86/boot: Parse SRAT address from RSDP and store immovable memory Message-ID: <20190121094214.GC15754@localhost.localdomain> References: <20190107032243.25324-1-fanc.fnst@cn.fujitsu.com> <20190107032243.25324-6-fanc.fnst@cn.fujitsu.com> <20190116110158.GC15409@zn.tnic> <20190121093348.GB15754@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190121093348.GB15754@localhost.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [10.167.225.56] X-yoursite-MailScanner-ID: B585A4C47E9E.AEE49 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: fanc.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 21, 2019 at 05:33:48PM +0800, Chao Fan wrote: >On Wed, Jan 16, 2019 at 12:01:58PM +0100, Borislav Petkov wrote: >>On Mon, Jan 07, 2019 at 11:22:42AM +0800, Chao Fan wrote: >[...] >>> + >>> +/* Determine RSDP, based on acpi_os_get_root_pointer(). */ >>> +static acpi_physical_address get_rsdp_addr(void) >>> +{ >>> + acpi_physical_address pa; >>> + >>> + pa = get_acpi_rsdp(); >>> + >>> + if (!pa) >>> + pa = efi_get_rsdp_addr(); >>> + >>> + if (!pa) >>> + pa = bios_get_rsdp_addr(); >>> + >>> + return pa; >>> +} > >Hi Boris, > >Talking in Kairui's thread may mislead you, let me clarify: >I mean I am going to change get_rsdp_addr(). Since I see ACPI code: > >>acpi_physical_address __init acpi_os_get_root_pointer(void) >>{ >> acpi_physical_address pa; >> >>#ifdef CONFIG_KEXEC >> if (acpi_rsdp) >> return acpi_rsdp; >>#endif >> pa = acpi_arch_get_root_pointer(); >> if (pa) >> return pa; > >So we need to parse boot_params->acpi_rsdp_addr also between KEXEC and >EFI: > >static acpi_physical_address get_rsdp_addr(void) >{ > acpi_physical_address pa; > > pa = get_acpi_rsdp(); > > if (!pa) >/* This line will be added in next version.*/ > pa = boot_params->acpi_rsdp_addr; > > if (!pa) > pa = efi_get_rsdp_addr(); > > if (!pa) > pa = bios_get_rsdp_addr(); > >/* If no acpi_rsdp_addr found in boot_params, fill in it here. */ > > return pa; >} Or I clear this function as: static acpi_physical_address get_rsdp_addr(void) { acpi_physical_address pa; pa = get_acpi_rsdp(); if (!pa) pa = boot_params->acpi_rsdp_addr; if (!pa) pa = efi_get_rsdp_addr(); if (!pa) pa = bios_get_rsdp_addr(); if (pa && !boot_params->acpi_rsdp_addr) boot_params->acpi_rsdp_addr = pa; return pa; } This version may look better, it does not need a bool. Thanks, Chao Fan > >Then you said I shall fill the boot_params->acpi_rsdp_addr, so in my >understanding, if there is no acpi_rsdp_addr found in boot_params, >we can parse RSDP by EFI/BIOS then fill it, other wise if it's found >int boot_params, we need't to fill it. > >Thanks, >Chao Fan