From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/4] perf record: apply affinity masks when reading mmap buffers
Date: Mon, 21 Jan 2019 12:54:28 +0100 [thread overview]
Message-ID: <20190121115428.GA3852@krava> (raw)
In-Reply-To: <ba339341-d73e-e341-5881-a9ec0eb852a5@linux.intel.com>
On Wed, Jan 16, 2019 at 12:23:05PM +0300, Alexey Budankov wrote:
SNIP
> static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evlist,
> bool overwrite)
> {
> @@ -755,6 +768,7 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli
> struct perf_mmap *map = &maps[i];
>
> if (map->base) {
> + record__adjust_affinity(rec, map);
> if (!record__aio_enabled(rec)) {
> if (perf_mmap__push(map, rec, record__pushfn) != 0) {
> rc = -1;
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 08cedb643ea6..178d3280ba62 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -1032,7 +1032,11 @@ int perf_evlist__mmap_ex(struct perf_evlist *evlist, unsigned int pages,
> * Its value is decided by evsel's write_backward.
> * So &mp should not be passed through const pointer.
> */
> - struct mmap_params mp = { .nr_cblocks = nr_cblocks, .affinity = affinity };
> + struct mmap_params mp = {
> + .nr_cblocks = nr_cblocks,
> + .affinity = affinity,
> + .cpu_map = cpu_map__new(NULL) /* from /sys/devices/system/cpu/online */
> + };
cpu_map won't get released.. if there's no better solution,
at least we could have it as static in build_node_mask..
this way it will be created only once
jirka
next prev parent reply other threads:[~2019-01-21 11:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 9:16 [PATCH v4 0/4] Reduce NUMA related overhead in perf record profiling on large server systems Alexey Budankov
2019-01-16 9:21 ` [PATCH v4 1/4] perf record: allocate affinity masks Alexey Budankov
2019-01-16 9:22 ` [PATCH v4 2/4] perf record: bind the AIO user space buffers to nodes Alexey Budankov
2019-01-16 9:23 ` [PATCH v4 3/4] perf record: apply affinity masks when reading mmap buffers Alexey Budankov
2019-01-21 11:54 ` Jiri Olsa [this message]
2019-01-22 12:55 ` Alexey Budankov
2019-01-16 9:23 ` [PATCH v4 4/4] perf record: implement --affinity=node|cpu option Alexey Budankov
2019-01-21 11:54 ` Jiri Olsa
2019-01-22 12:55 ` Alexey Budankov
-- strict thread matches above, loose matches on Subject: below --
2019-01-10 10:46 [PATCH v4 0/4] Reduce NUMA related overhead in perf record profiling on large server systems Alexey Budankov
2019-01-10 11:24 ` [PATCH v4 3/4] perf record: apply affinity masks when reading mmap buffers Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121115428.GA3852@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox