From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Thomas Richter <tmricht@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com
Subject: Re: [PATCHv2 1/3] perf report: Display s390 diagnostic counter sets
Date: Mon, 21 Jan 2019 14:13:36 +0100 [thread overview]
Message-ID: <20190121131336.GC3852@krava> (raw)
In-Reply-To: <20190120181814.GB8591@krava>
On Sun, Jan 20, 2019 at 07:18:14PM +0100, Jiri Olsa wrote:
> On Thu, Jan 17, 2019 at 11:00:53AM -0300, Arnaldo Carvalho de Melo wrote:
>
> SNIP
>
> > --- a/tools/perf/util/python-ext-sources
> > +++ b/tools/perf/util/python-ext-sources
> > @@ -25,6 +25,7 @@ util/parse-branch-options.c
> > util/rblist.c
> > util/counts.c
> > util/print_binary.c
> > +util/s390-sample-raw.c
> > util/strlist.c
> > util/trace-event.c
> > ../lib/rbtree.c
>
> hi,
> this change breaks the python module:
>
> >>> import perf
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> ImportError: ./perf.so: undefined symbol: color_fprintf
>
> changelog doesn't say anything about python related change
I made some chenages and movedthat raw sample code
under s390.. which cured the python module, but
I haven't tested it on s390.
Could you please check if code in here works for you:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/s390
if it works, I'll post it
thanks,
jirka
next prev parent reply other threads:[~2019-01-21 13:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:30 [Patchv2 0/3] perf report: Display CPU Measurement facility counter sets Thomas Richter
2019-01-17 9:30 ` [PATCHv2 1/3] perf report: Display s390 diagnostic " Thomas Richter
2019-01-17 14:00 ` Arnaldo Carvalho de Melo
2019-01-18 8:39 ` Thomas-Mich Richter
2019-01-22 10:15 ` [tip:perf/core] perf report: Display arch specific diagnostic counter sets, starting with s390 tip-bot for Thomas Richter
2019-01-20 18:18 ` [PATCHv2 1/3] perf report: Display s390 diagnostic counter sets Jiri Olsa
2019-01-21 13:13 ` Jiri Olsa [this message]
2019-01-21 14:10 ` Thomas-Mich Richter
2019-01-21 14:17 ` Arnaldo Carvalho de Melo
2019-01-21 18:34 ` Jiri Olsa
2019-01-22 0:01 ` Arnaldo Carvalho de Melo
2019-01-21 19:17 ` Arnaldo Carvalho de Melo
2019-01-17 9:30 ` [PATCHv2 2/3] perf report: Display names in " Thomas Richter
2019-01-17 14:02 ` Arnaldo Carvalho de Melo
2019-01-22 10:16 ` [tip:perf/core] " tip-bot for Thomas Richter
2019-01-17 9:30 ` [PATCHv2 3/3] perf report: s390 dump counter set data to file Thomas Richter
2019-01-17 14:03 ` Arnaldo Carvalho de Melo
2019-01-22 10:16 ` [tip:perf/core] perf report: Dump s390 " tip-bot for Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121131336.GC3852@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).