From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: He Kuang <hekuang@huawei.com>,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf top: Fix wrong hottest instruction highlighted
Date: Mon, 21 Jan 2019 11:10:50 -0300 [thread overview]
Message-ID: <20190121141050.GA15707@kernel.org> (raw)
In-Reply-To: <20190120184043.GD8591@krava>
Em Sun, Jan 20, 2019 at 07:40:43PM +0100, Jiri Olsa escreveu:
> On Mon, Jan 21, 2019 at 12:05:22AM +0800, He Kuang wrote:
> > Annotation line's percentage is compared and inserted into rbtree, but the
> > percent field of 'struct annotation_data' is an array, the comparison
> > result between them is the address difference.
> >
> > This patch compares the right slot of percent array according to
> > opts->percent_type and makes things right.
> >
> > The problem can be reproduced by pressing 'H' in perf top annotation view.
> > It should highlight the instruction line which has the highest sampling
> > percentage.
> >
> > Signed-off-by: He Kuang <hekuang@huawei.com>
>
> Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2019-01-21 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 16:05 [PATCH] perf top: Fix wrong hottest instruction highlighted He Kuang
2019-01-20 18:40 ` Jiri Olsa
2019-01-21 14:10 ` Arnaldo Carvalho de Melo [this message]
2019-01-22 11:37 ` [tip:perf/urgent] " tip-bot for He Kuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121141050.GA15707@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox