Re: [PATCHv2 1/3] perf report: Display s390 diagnostic counter sets

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Mon, Jan 21, 2019 at 02:13:36PM +0100, Jiri Olsa escreveu:
> On Sun, Jan 20, 2019 at 07:18:14PM +0100, Jiri Olsa wrote:
> > On Thu, Jan 17, 2019 at 11:00:53AM -0300, Arnaldo Carvalho de Melo wrote:
> > 
> > SNIP
> > 
> > > --- a/tools/perf/util/python-ext-sources
> > > +++ b/tools/perf/util/python-ext-sources
> > > @@ -25,6 +25,7 @@ util/parse-branch-options.c
> > >  util/rblist.c
> > >  util/counts.c
> > >  util/print_binary.c
> > > +util/s390-sample-raw.c
> > >  util/strlist.c
> > >  util/trace-event.c
> > >  ../lib/rbtree.c
> > 
> > hi,
> > this change breaks the python module:
> > 
> >   >>> import perf
> >   Traceback (most recent call last):
> >     File "<stdin>", line 1, in <module>
> >   ImportError: ./perf.so: undefined symbol: color_fprintf
> > 
> > changelog doesn't say anything about python related change
> 
> I made some chenages and movedthat raw sample code
> under s390.. which cured the python module, but
> I haven't tested it on s390.

Nope, I explicitely asked him to build that code for all arches, as we
want to process s390 perf.data files on a x86 or arm or any other arch.

I stumbled on this as well, I think the way to go is to get the
color_fprintf bits in a separate object to avoid dragging more stuff to
the perf binding set of objects and then add that to the python binding.
 
> Could you please check if code in here works for you:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/s390
> 
> if it works, I'll post it
> 
> thanks,
> jirka

-- 

- Arnaldo