From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 579C3C31681 for ; Mon, 21 Jan 2019 18:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F4A321019 for ; Mon, 21 Jan 2019 18:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727790AbfAUSel (ORCPT ); Mon, 21 Jan 2019 13:34:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40934 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726627AbfAUSel (ORCPT ); Mon, 21 Jan 2019 13:34:41 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DED55A403C; Mon, 21 Jan 2019 18:34:40 +0000 (UTC) Received: from krava (unknown [10.40.205.159]) by smtp.corp.redhat.com (Postfix) with SMTP id 7B5835D6AA; Mon, 21 Jan 2019 18:34:38 +0000 (UTC) Date: Mon, 21 Jan 2019 19:34:37 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Thomas Richter , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com Subject: Re: [PATCHv2 1/3] perf report: Display s390 diagnostic counter sets Message-ID: <20190121183437.GB11396@krava> References: <20190117093003.96287-1-tmricht@linux.ibm.com> <20190117093003.96287-2-tmricht@linux.ibm.com> <20190117140053.GJ11922@kernel.org> <20190120181814.GB8591@krava> <20190121131336.GC3852@krava> <20190121141748.GC15707@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190121141748.GC15707@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 21 Jan 2019 18:34:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 21, 2019 at 11:17:48AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jan 21, 2019 at 02:13:36PM +0100, Jiri Olsa escreveu: > > On Sun, Jan 20, 2019 at 07:18:14PM +0100, Jiri Olsa wrote: > > > On Thu, Jan 17, 2019 at 11:00:53AM -0300, Arnaldo Carvalho de Melo wrote: > > > > > > SNIP > > > > > > > --- a/tools/perf/util/python-ext-sources > > > > +++ b/tools/perf/util/python-ext-sources > > > > @@ -25,6 +25,7 @@ util/parse-branch-options.c > > > > util/rblist.c > > > > util/counts.c > > > > util/print_binary.c > > > > +util/s390-sample-raw.c > > > > util/strlist.c > > > > util/trace-event.c > > > > ../lib/rbtree.c > > > > > > hi, > > > this change breaks the python module: > > > > > > >>> import perf > > > Traceback (most recent call last): > > > File "", line 1, in > > > ImportError: ./perf.so: undefined symbol: color_fprintf > > > > > > changelog doesn't say anything about python related change > > > > I made some chenages and movedthat raw sample code > > under s390.. which cured the python module, but > > I haven't tested it on s390. > > Nope, I explicitely asked him to build that code for all arches, as we > want to process s390 perf.data files on a x86 or arm or any other arch. > aah, so this actualy works over the s390 perf archive data on x86 host? I missed that in the original conversation, sry for noise jirka > I stumbled on this as well, I think the way to go is to get the > color_fprintf bits in a separate object to avoid dragging more stuff to > the perf binding set of objects and then add that to the python binding. > > > Could you please check if code in here works for you: > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > > perf/s390 > > > > if it works, I'll post it > > > > thanks, > > jirka > > -- > > - Arnaldo