Re: [PATCH] mm: no need to check return value of debugfs_create functions

Michal Hocko
2019-01-22T17:29:50Z

On Tue 22-01-19 17:27:49, Greg KH wrote:
> On Tue, Jan 22, 2019 at 05:07:01PM +0100, Michal Hocko wrote:
[...]
> > sounds like a poor design goal to me but not mine code to maintain so...
>
> The design goal was to make it as simple as possible to use, and that
> includes "you do not care about the return value". Now we do have to
> return a value because some people need that for when they want to make
> a subdirectory, or remove the file later on, otherwise I would have just
> had everything be a void return function :)

I suspect that you are making assumptions which might change in the
future and this whole mess will be unfixable. But whatever I do not care
about debugfs at all.
--
Michal Hocko
SUSE Labs