From: Andi Kleen <ak@linux.intel.com>
To: kan.liang@linux.intel.com
Cc: peterz@infradead.org, acme@kernel.org, tglx@linutronix.de,
mingo@redhat.com, linux-kernel@vger.kernel.org,
eranian@google.com, jolsa@redhat.com, namhyung@kernel.org
Subject: Re: [PATCH 10/12] perf script: Add support for PERF_SAMPLE_CODE_PAGE_SIZE
Date: Tue, 22 Jan 2019 09:11:44 -0800 [thread overview]
Message-ID: <20190122171144.GU6118@tassilo.jf.intel.com> (raw)
In-Reply-To: <1548090318-19149-10-git-send-email-kan.liang@linux.intel.com>
> + PERF_OUTPUT_CODE_PAGE_SIZE = 1UL << 32,
That won't work on 32bit. You need 1ULL
Also might want to audit that noone puts these flags into
an int.
-Andi
next prev parent reply other threads:[~2019-01-22 17:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 17:05 [PATCH 01/12] perf/core, x86: Add PERF_SAMPLE_DATA_PAGE_SIZE kan.liang
2019-01-21 17:05 ` [PATCH 02/12] perf tools: Support new sample type for data page size kan.liang
2019-01-21 17:05 ` [PATCH 03/12] perf script: Support " kan.liang
2019-01-21 17:05 ` [PATCH 04/12] perf sort: Add sort option for " kan.liang
2019-01-21 17:05 ` [PATCH 05/12] perf mem: Clean up output format and sort order string kan.liang
2019-01-21 17:05 ` [PATCH 06/12] perf mem: Support data page size kan.liang
2019-01-21 17:05 ` [PATCH 07/12] perf test: Add test case for PERF_SAMPLE_DATA_PAGE_SIZE kan.liang
2019-01-21 17:05 ` [PATCH 08/12] perf/core, x86: Add support for PERF_SAMPLE_CODE_PAGE_SIZE kan.liang
2019-01-21 17:05 ` [PATCH 09/12] perf tools: " kan.liang
2019-01-21 17:05 ` [PATCH 10/12] perf script: " kan.liang
2019-01-22 17:11 ` Andi Kleen [this message]
2019-01-23 14:40 ` Liang, Kan
2019-01-21 17:05 ` [PATCH 11/12] perf report: " kan.liang
2019-01-21 17:05 ` [PATCH 12/12] perf test: Add test case " kan.liang
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 19:56 [PATCH 00/12] Add the page size in the perf record (user tools) kan.liang
2020-11-17 19:56 ` [PATCH 10/12] perf script: Add support for PERF_SAMPLE_CODE_PAGE_SIZE kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122171144.GU6118@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox