From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 624A9C282C3 for ; Tue, 22 Jan 2019 17:58:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30A3421019 for ; Tue, 22 Jan 2019 17:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726838AbfAVR60 (ORCPT ); Tue, 22 Jan 2019 12:58:26 -0500 Received: from mail.bootlin.com ([62.4.15.54]:45449 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfAVR6Z (ORCPT ); Tue, 22 Jan 2019 12:58:25 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 12FDB209BF; Tue, 22 Jan 2019 18:58:23 +0100 (CET) Received: from localhost (unknown [80.12.58.130]) by mail.bootlin.com (Postfix) with ESMTPSA id 8246C20A15; Tue, 22 Jan 2019 18:57:52 +0100 (CET) Date: Tue, 22 Jan 2019 18:57:52 +0100 From: Alexandre Belloni To: Sam Ravnborg Cc: Alessandro Zummo , Andrew Jeffery , Fabio Estevam , Joel Stanley , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , Urs =?iso-8859-1?Q?F=E4ssler?= , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v3 0/6] add quartz load support to NXP rtc drivers Message-ID: <20190122175752.GD16702@piout.net> References: <20190119090031.29147-1-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190119090031.29147-1-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/01/2019 10:00:25+0100, Sam Ravnborg wrote: > Respin of patchset on top of v5.0-rc2 with feedback addressed (thanks!) > > Introduce a new generic property "quartz-load-femtofarad" > to specify the quartz load. > The default value is selected to match the current Linux > drivers, so there are no behavior changes if a binding do not > specify the quarts-load. > The unit is femtofarads because several RTC's define the quarts load > in steps of 0.5 pF. > > The two drivers rtc-pcf8523 and rtc-pcf85063 are both > updated to use the new binding. > Previously pcf8523 hardcoded the quartz load to 12.5pF, and > pcf85063 used the reset default of 7pF. > With this patchset it can now be specified in the DT, > if the defaults are not OK. > > The patch-set is tested on a proprietary board for both > RTC variants (v2 variant only as there was only trivial changes in v3). > > Sam > > v3: > - Document generic property "quartz-load-femtofarads" in rtc.txt (Rob) > - Fix indent several places - ups (Alexandre) > - Use the simpler name "rtc" in DT examples (Rob) > - Collected "Reviewed by's" > > v2: > - Introduce a generic property "quartz-load-femtofarads" > - Add femtofarads to property-units.txt > - Make the changes backward compatible > - Reduced logging > - Warn, when we continue with a default value > - Tested, by Søren Andersen, on real HW > - Rebased on top of v5.0-rc1 > > Sam > > Sam Ravnborg (6): > devicetree: property-units: Add femtofarads unit > dt-bindings: rtc: Add quartz-load-femtofarads property > dt-binding: pcf8523: add xtal load capacitance > dt-binding: pcf85063: add xtal load capacitance > rtc: pcf8523: set xtal load capacitance from DT > rtc: pcf85063: set xtal load capacitance from DT > All applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com