Re: [PATCH v3 04/10] dt-bindings: soc: qcom: Add AOSS QMP binding

Stephen Boyd
2019-01-22T19:28:27Z

Quoting Bjorn Andersson (2019-01-22 11:25:37)
> On Tue 22 Jan 11:04 PST 2019, Stephen Boyd wrote:
>
> > Quoting Bjorn Andersson (2019-01-21 21:51:06)
> > > Add binding for the QMP based side-channel communication mechanism to
> > > the AOSS, which is used to control resources not exposed through the
> > > RPMh interface.
> > >
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > ---
> > >
> > > Changes since v2:
> > > - Update indentation of example
> > > - Add colling device subnodes to the description
> > >
> > > .../bindings/soc/qcom/qcom,aoss-qmp.txt | 75 +++++++++++++++++++
> > > include/dt-bindings/power/qcom-aoss-qmp.h | 15 ++++
> > > 2 files changed, 90 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> > > create mode 100644 include/dt-bindings/power/qcom-aoss-qmp.h
> > >
> > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> > > new file mode 100644
> > > index 000000000000..881dc8c7907a
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> > > @@ -0,0 +1,75 @@
> > > +Qualcomm Always-On Subsystem side channel binding
> > > +
> > > +This binding describes the hardware component responsible for side channel
> > > +requests to the always-on subsystem (AOSS), used for certain power management
> > > +requests that is not handled by the standard RPMh interface. Each client in the
> > > +SoC has it's own block of message RAM and IRQ for communication with the AOSS.
> > > +The protocol used to communicate in the message RAM is known as QMP.
> >
> > Just curious if QMP is "Qualcomm Messaging Protocol"? I don't think it's
> > ever spelled out in this patchset.
> >
>
> I believe that is the case, would you like me to spell it out?

Yes, at least once would be great. Thanks.