* [PATCH] staging: ks7010: remove unnecessary parentheses
@ 2019-01-23 2:18 Matt McCoy
2019-01-23 2:45 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Matt McCoy @ 2019-01-23 2:18 UTC (permalink / raw)
To: Matt McCoy
Cc: Greg Kroah-Hartman, Sergio Paracuellos, Quytelda Kahja, devel,
linux-kernel
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Matt McCoy <mattmccoy110@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 065bce1..d938b09 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -35,7 +35,7 @@ static inline u8 get_byte(struct ks_wlan_private *priv)
{
u8 data;
- data = *(priv->rxp)++;
+ data = *priv->rxp++;
/* length check in advance ! */
--(priv->rx_size);
return data;
@@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
"- rate_set_size=%d\n",
ap->bssid[0], ap->bssid[1], ap->bssid[2],
ap->bssid[3], ap->bssid[4], ap->bssid[5],
- &(ap->ssid.body[0]),
+ &ap->ssid.body[0],
ap->rate_set.body[0], ap->rate_set.body[1],
ap->rate_set.body[2], ap->rate_set.body[3],
ap->rate_set.body[4], ap->rate_set.body[5],
@@ -732,7 +732,7 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
netdev_dbg(priv->net_dev, " scan_ind_count=%d :: aplist.size=%d\n",
priv->scan_ind_count, priv->aplist.size);
get_ap_information(priv, (struct ap_info *)(priv->rxp),
- &(priv->aplist.ap[priv->scan_ind_count - 1]));
+ &priv->aplist.ap[priv->scan_ind_count - 1]);
priv->aplist.size = priv->scan_ind_count;
} else {
netdev_dbg(priv->net_dev, " count over :: scan_ind_count=%d\n",
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: ks7010: remove unnecessary parentheses
2019-01-23 2:18 [PATCH] staging: ks7010: remove unnecessary parentheses Matt McCoy
@ 2019-01-23 2:45 ` Joe Perches
2019-01-23 22:21 ` Matt McCoy
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2019-01-23 2:45 UTC (permalink / raw)
To: Matt McCoy
Cc: Greg Kroah-Hartman, Sergio Paracuellos, Quytelda Kahja, devel,
linux-kernel
On Tue, 2019-01-22 at 21:18 -0500, Matt McCoy wrote:
> Remove unnecessary parentheses reported by checkpatch.
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
> "- rate_set_size=%d\n",
> ap->bssid[0], ap->bssid[1], ap->bssid[2],
> ap->bssid[3], ap->bssid[4], ap->bssid[5],
> - &(ap->ssid.body[0]),
> + &ap->ssid.body[0],
> ap->rate_set.body[0], ap->rate_set.body[1],
> ap->rate_set.body[2], ap->rate_set.body[3],
> ap->rate_set.body[4], ap->rate_set.body[5],
This bit:
[]
netdev_dbg(priv->net_dev, "Link AP\n"
"- bssid=%02X:%02X:%02X:%02X:%02X:%02X\n"
[]
ap->bssid[0], ap->bssid[1], ap->bssid[2],
should instead use the vsprintf %pM extension
"- bssid: %pM\n"
[]
ap->bssid,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: ks7010: remove unnecessary parentheses
2019-01-23 2:45 ` Joe Perches
@ 2019-01-23 22:21 ` Matt McCoy
0 siblings, 0 replies; 3+ messages in thread
From: Matt McCoy @ 2019-01-23 22:21 UTC (permalink / raw)
To: Joe Perches
Cc: Greg Kroah-Hartman, Sergio Paracuellos, Quytelda Kahja, devel,
linux-kernel
On Tue, Jan 22, 2019 at 06:45:37PM -0800, Joe Perches wrote:
> On Tue, 2019-01-22 at 21:18 -0500, Matt McCoy wrote:
> > Remove unnecessary parentheses reported by checkpatch.
> []
> > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> []
> > @@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
> > "- rate_set_size=%d\n",
> > ap->bssid[0], ap->bssid[1], ap->bssid[2],
> > ap->bssid[3], ap->bssid[4], ap->bssid[5],
> > - &(ap->ssid.body[0]),
> > + &ap->ssid.body[0],
> > ap->rate_set.body[0], ap->rate_set.body[1],
> > ap->rate_set.body[2], ap->rate_set.body[3],
> > ap->rate_set.body[4], ap->rate_set.body[5],
>
> This bit:
>
> []
> netdev_dbg(priv->net_dev, "Link AP\n"
> "- bssid=%02X:%02X:%02X:%02X:%02X:%02X\n"
> []
> ap->bssid[0], ap->bssid[1], ap->bssid[2],
>
> should instead use the vsprintf %pM extension
>
> "- bssid: %pM\n"
> []
> ap->bssid,
>
>
Should I just make a v2 of this patch with 2 parts ?
One being this change and the other using the %pM extension.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-23 22:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-23 2:18 [PATCH] staging: ks7010: remove unnecessary parentheses Matt McCoy
2019-01-23 2:45 ` Joe Perches
2019-01-23 22:21 ` Matt McCoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox