From: Greg KH <gregkh@linuxfoundation.org>
To: Antoine Robertson <antoinerbrtsn@gmail.com>
Cc: jslaby@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] tty: moxa: Fix coding style issues
Date: Wed, 23 Jan 2019 08:06:23 +0100 [thread overview]
Message-ID: <20190123070623.GE27466@kroah.com> (raw)
In-Reply-To: <20190122223055.6877-1-antoinerbrtsn@gmail.com>
On Tue, Jan 22, 2019 at 05:30:55PM -0500, Antoine Robertson wrote:
> Fix coding style issues
That is really vague, you need to say exactly what type of coding style
fixes you made here.
And if you made more than one "type" of fix, then you need to break the
patch up into a series, only doing one "type" of fix per patch.
Yeah, that's a pain for when there are only tiny things that need to be
changed, but that way it makes it easier for reviewers, and for fixing
if it turns out any of your changes was not ok.
I recommend, if you want to do coding style fixes, to do so in the
drivers/staging/ part of the kernel. That area has a lot more work to
be done and you don't end up doing tiny things like this.
thanks,
greg k-h
prev parent reply other threads:[~2019-01-23 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 22:30 [PATCH v3] tty: moxa: Fix coding style issues Antoine Robertson
2019-01-23 7:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123070623.GE27466@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=antoinerbrtsn@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox