From: Boris Brezillon <bbrezillon@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <robert.jarzmik@free.fr>, <dwmw2@infradead.org>,
<computersforpeace@gmail.com>, <marek.vasut@gmail.com>,
<richard@nod.at>, <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH -next] mtd: docg3: Fix passing zero to 'PTR_ERR' warning in doc_probe_device
Date: Wed, 23 Jan 2019 10:52:53 +0100 [thread overview]
Message-ID: <20190123105253.1f4487f2@bbrezillon> (raw)
In-Reply-To: <86533285-e800-5cc0-f495-88fff8326b5a@huawei.com>
On Wed, 23 Jan 2019 17:43:58 +0800
YueHaibing <yuehaibing@huawei.com> wrote:
> On 2019/1/23 17:12, Boris Brezillon wrote:
> > On Wed, 23 Jan 2019 14:58:27 +0800
> > YueHaibing <yuehaibing@huawei.com> wrote:
> >
> >> Fix a static code checker warning:
> >> drivers/mtd/devices/docg3.c:1875
> >> doc_probe_device() warn: passing zero to 'ERR_PTR'
> >>
> >> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >> ---
> >> drivers/mtd/devices/docg3.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> >> index 4c94fc0..60ddc38 100644
> >> --- a/drivers/mtd/devices/docg3.c
> >> +++ b/drivers/mtd/devices/docg3.c
> >> @@ -1872,7 +1872,7 @@ doc_probe_device(struct docg3_cascade *cascade, int floor, struct device *dev)
> >> nomem2:
> >> kfree(docg3);
> >> nomem1:
> >> - return ERR_PTR(ret);
> >> + return ret ? ERR_PTR(ret) : NULL;
> >> }
> >>
> >
> > This is not the right fix, you should instead set ret to -EINVAL:
>
> Thanks , will fix it in v2.
>
> And seems doc_probe_device cannot return NULL. The NULL check of doc_probe_device
> in docg3_probe also can been removed, right?
Hm, looks like the ret = 0 was intentional (to identify when ID is
invalid). Let's just keep your initial patch.
next prev parent reply other threads:[~2019-01-23 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 6:58 [PATCH -next] mtd: docg3: Fix passing zero to 'PTR_ERR' warning in doc_probe_device YueHaibing
2019-01-23 9:12 ` Boris Brezillon
2019-01-23 9:43 ` YueHaibing
2019-01-23 9:52 ` Boris Brezillon [this message]
2019-01-23 20:49 ` Robert Jarzmik
2019-01-28 9:36 ` [-next] " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123105253.1f4487f2@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox