Re: [PATCH 4/7] crypto: cavium: zip: no need to check return value of debugfs_create functions

Jan Glauber
2019-01-23T13:30:34Z

On Tue, Jan 22, 2019 at 04:14:19PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Robert Richter <rrichter@cavium.com>
> Cc: Jan Glauber <jglauber@cavium.com>
> Cc: linux-crypto@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/crypto/cavium/zip/zip_main.c | 52 ++++++----------------------
> 1 file changed, 11 insertions(+), 41 deletions(-)

Reviewed-by: Jan Glauber <jglauber@cavium.com>

thanks,
Jan