Re: [PATCH net-next 03/10] net: macsec: move some definitions in a dedicated header

David Miller
2019-01-24T01:01:07Z

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 23 Jan 2019 12:11:37 -0800

> On 1/23/19 7:56 AM, Antoine Tenart wrote:
>> This patch moves some structure, type and identifier definitions into a
>> MACsec specific header. This patch does not modify how the MACsec code
>> is running and only move things around. This is a preparation for the
>> future MACsec hardware offloading support, which will re-use those
>> definitions outside macsec.c.
>>
>> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
>> ---
>> drivers/net/macsec.c | 164 +--------------------------------------
>> include/net/macsec.h | 178 +++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 179 insertions(+), 163 deletions(-)
>> create mode 100644 include/net/macsec.h
>>
>> diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
>> index 56e354305f76..c3a138dd4386 100644
>> --- a/drivers/net/macsec.c
>> +++ b/drivers/net/macsec.c
>> @@ -17,10 +17,9 @@
>> #include <net/sock.h>
>> #include <net/gro_cells.h>
>>
>> +#include <net/macsec.h>
>> #include <uapi/linux/if_macsec.h>
>
> I would probably go with include/linux/if_macsec.h and have
> uapi/linux/if_macsec.h include that file directly. This would be
> consistent with other types of network interfaces: bridge, vlan etc.

Agreed.