From: Thierry Reding <thierry.reding@gmail.com>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
padovan Gustavo <gustavo.padovan@collabora.com>,
maxime.ripard@bootlin.com, seanpaul@chromium.org,
hl@rock-chips.com, briannorris@chromium.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
nickey.yang@rock-chips.com
Subject: Re: [PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver
Date: Thu, 24 Jan 2019 17:18:12 +0100 [thread overview]
Message-ID: <20190124161812.GA10550@ulmo> (raw)
In-Reply-To: <fa732d7c529c28135b2c9a1ccf902d4658a53682.camel@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 2016 bytes --]
On Thu, Jan 24, 2019 at 12:01:55PM -0300, Ezequiel Garcia wrote:
> On Tue, 2018-10-30 at 10:15 +0100, Heiko Stuebner wrote:
> > From: Nickey Yang <nickey.yang@rock-chips.com>
> >
> > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel,
> > it is a MIPI dual-DSI panel.
> >
> > v4-resend:
> > - Thierry noted missing dt-bindings for v4 but forgot that he
> > already had applied them one kernel release back in
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ebc950fdff6d5f9250cd5a5a348af97f7d8508df
> > v4:
> > - address Philipp's comments
> > - real range for usleep_range and
> > - poweroff ordering in kingdisplay_panel_prepare
> > - return value beautification in panel_probe
> > - update author naming for full name
> > v3:
> > - address Thierry's comments
> > - error handling for init dsi writes in init
> > - unconditionally remove the panel
> > - don't use drm_panel_detach
> > - a bit of variable signednes wiggling
> > - I did talk to ChromeOS people and the delays really should be as short
> > as possible, so dropped the 100ms from the delay comments
> > v2:
> > - update timing + cmds from chromeos kernel
> > - new backlight API including switch to devm_of_find_backlight
> > - fix most of Sean Paul's comments
> > enable/prepare tracking seems something all panels do
> > - document origins of the init sequence
> > - lanes per dsi interface to 4 (two interfaces). Matches how tegra
> > and pending rockchip dual-dsi handle (dual-)dsi lanes
> > - spdx header instead of license boilerplate
> >
> > Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> Hm, this v4 patch has been stalling here for *four full months*.
>
> Which deity do we need to pray to get this one moving? ;-)
>
> Seriously, can someone please apply this?
If you care about this driver, perhaps you'd like to review and provide
a Reviewed-by?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-24 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 9:15 [PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver Heiko Stuebner
2019-01-24 15:01 ` Ezequiel Garcia
2019-01-24 16:18 ` Thierry Reding [this message]
2019-01-24 17:51 ` Sean Paul
2019-01-28 15:59 ` Thierry Reding
2019-01-29 0:48 ` Ezequiel Garcia
2019-01-28 15:58 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124161812.GA10550@ulmo \
--to=thierry.reding@gmail.com \
--cc=briannorris@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ezequiel@collabora.com \
--cc=gustavo.padovan@collabora.com \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=nickey.yang@rock-chips.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox