From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACBD1C282C5 for ; Thu, 24 Jan 2019 19:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71D44218E2 for ; Thu, 24 Jan 2019 19:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548358318; bh=DOBcEBFoJVh4kKGn+NStpKAlbj6nM+XYLNtIn+Prfgo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WCW/7eHDyQlDmRfkiKbzDm/gTjYgz2eHL/qLOI5BgIun8O/DTFz7Gd89fNAREnMDp QufGhjb1y1+NEmv0gtUeo9dmdad23rIWRebmt40q309b4kkYTRrkaT/73M3I/TbtpD jiF8Hcfn/RVV+MfFdx/en/eZ9bFsCfBH6QWd5PFg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731745AbfAXTb4 (ORCPT ); Thu, 24 Jan 2019 14:31:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:59726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731732AbfAXTby (ORCPT ); Thu, 24 Jan 2019 14:31:54 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB6ED218D4; Thu, 24 Jan 2019 19:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548358313; bh=DOBcEBFoJVh4kKGn+NStpKAlbj6nM+XYLNtIn+Prfgo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2iyGK6pWcOaJtuP4BLzVDhli01wvPzF5kfbk0b2j/+uFqZFHReHG876HB/0PAs6Rw VP82H+6x9z2FzkPVFW+qIjZHDXsJEi9GOJRDy2G7jAoPYyl7/deLDu4WPY43ZZIoEW 0Xj61OUR5yrg9JgDpU1S5H1I+RWGXV0o3oYRMC1w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, yupeng , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 28/63] net: call sk_dst_reset when set SO_DONTROUTE Date: Thu, 24 Jan 2019 20:20:17 +0100 Message-Id: <20190124190158.304665219@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124190155.176570028@linuxfoundation.org> References: <20190124190155.176570028@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 0fbe82e628c817e292ff588cd5847fc935e025f2 ] after set SO_DONTROUTE to 1, the IP layer should not route packets if the dest IP address is not in link scope. But if the socket has cached the dst_entry, such packets would be routed until the sk_dst_cache expires. So we should clean the sk_dst_cache when a user set SO_DONTROUTE option. Below are server/client python scripts which could reprodue this issue: server side code: ========================================================================== import socket import struct import time s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) s.bind(('0.0.0.0', 9000)) s.listen(1) sock, addr = s.accept() sock.setsockopt(socket.SOL_SOCKET, socket.SO_DONTROUTE, struct.pack('i', 1)) while True: sock.send(b'foo') time.sleep(1) ========================================================================== client side code: ========================================================================== import socket import time s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) s.connect(('server_address', 9000)) while True: data = s.recv(1024) print(data) ========================================================================== Signed-off-by: yupeng Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/core/sock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/sock.c b/net/core/sock.c index 01cae48d6eef..a88579589946 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -735,6 +735,7 @@ int sock_setsockopt(struct socket *sock, int level, int optname, break; case SO_DONTROUTE: sock_valbool_flag(sk, SOCK_LOCALROUTE, valbool); + sk_dst_reset(sk); break; case SO_BROADCAST: sock_valbool_flag(sk, SOCK_BROADCAST, valbool); -- 2.19.1