From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: hypfs: no need to check return value of debugfs_create functions
Date: Fri, 25 Jan 2019 09:47:58 +0100 [thread overview]
Message-ID: <20190125084758.GB3561@osiris> (raw)
In-Reply-To: <20190122152151.16139-1-gregkh@linuxfoundation.org>
On Tue, Jan 22, 2019 at 04:21:00PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: linux-s390@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> arch/s390/hypfs/hypfs.h | 6 +++---
> arch/s390/hypfs/hypfs_dbfs.c | 8 ++------
> arch/s390/hypfs/hypfs_diag.c | 9 ++++-----
> arch/s390/hypfs/hypfs_diag0c.c | 3 ++-
> arch/s390/hypfs/hypfs_sprp.c | 6 +++---
> arch/s390/hypfs/hypfs_vm.c | 3 ++-
> arch/s390/hypfs/inode.c | 11 +++--------
> 7 files changed, 19 insertions(+), 27 deletions(-)
Applied, thanks!
prev parent reply other threads:[~2019-01-25 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:21 [PATCH] s390: hypfs: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-25 8:47 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125084758.GB3561@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox