Re: [PATCH] kcov: convert kcov.refcount to refcount_t

Peter Zijlstra
2019-01-25T10:32:05Z

On Fri, Jan 25, 2019 at 09:02:42AM +0000, Reshetova, Elena wrote:
> > > I suppose we can add smp_acquire__after_ctrl_dep() on the true branch.
> > > Then it reall does become rel_acq.
> > >
> > > A wee something like so (I couldn't find an arm64 refcount, even though
> > > I have distinct memories of talk about it).
> >
> > In the end, arm and arm64 chose to use REFCOUNT_FULL unconditionally,
> > so there's no arch-specific implementation.
> >
> > > This isn't compiled, and obviously needs comment/documentation updates
> > > to go along with it.
> >
> > Elena, can you do the doc updates?
>
> Well, doc updates should go with below patch + and additional testing...
>
> Peter, should I create a full version from below with doc/comments
> updates, run the whole thing via zero day and send to you if it all looks ok?

If you have to time to do so, yes please!