From: Jonathan Cameron <jic23@kernel.org>
To: Robert Eshleman <bobbyeshleman@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Add device tree binding documentation for MAX44009
Date: Sat, 26 Jan 2019 21:04:11 +0000 [thread overview]
Message-ID: <20190126210411.1efcde38@archlinux> (raw)
In-Reply-To: <7201ee3e0e1c119fa521ed33793be96eaa0eb159.1548529751.git.bobbyeshleman@gmail.com>
On Sat, 26 Jan 2019 11:16:21 -0800
Robert Eshleman <bobbyeshleman@gmail.com> wrote:
> Signed-off-by: Robert Eshleman <bobbyeshleman@gmail.com>
Looks good to me. As we are going for a v3 due to patch 1, plenty
of time for others to comment.
Thanks,
Jonathan
> ---
> .../bindings/iio/light/max44009.txt | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/max44009.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/light/max44009.txt b/Documentation/devicetree/bindings/iio/light/max44009.txt
> new file mode 100644
> index 000000000000..b287d7732e37
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/max44009.txt
> @@ -0,0 +1,25 @@
> +* MAX44009 Ambient Light Sensor
> +
> +Required properties:
> +
> +- compatible: should be "maxim,max44009"
> +- reg: the I2C address of the device (default is <0x4a>)
> +
> +Optional properties:
> +
> +- interrupts: interrupt mapping for GPIO IRQ. Should be configured with
> + IRQ_TYPE_EDGE_FALLING.
> +
> +Refer to interrupt-controller/interrupts.txt for generic interrupt client
> +node bindings.
> +
> +Example:
> +
> +max44009: max44009@4a {
> + compatible = "maxim,max44009";
> + reg = <0x4a>;
> +
> + interrupt-parent = <&gpio1>;
> + interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
> +};
> +
next prev parent reply other threads:[~2019-01-26 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 19:15 [PATCH v2 1/2] Add driver support for MAX44009 light sensor Robert Eshleman
2019-01-26 19:16 ` [PATCH v2 2/2] Add device tree binding documentation for MAX44009 Robert Eshleman
2019-01-26 21:04 ` Jonathan Cameron [this message]
2019-01-26 21:02 ` [PATCH v2 1/2] Add driver support for MAX44009 light sensor Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190126210411.1efcde38@archlinux \
--to=jic23@kernel.org \
--cc=bobbyeshleman@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox