From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B7D0C282C8 for ; Mon, 28 Jan 2019 16:02:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DAAF2082E for ; Mon, 28 Jan 2019 16:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548691326; bh=bfYfdsACu4/XDMdOLmpqe4guQy3fQQGA9ejQermmO4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=smKDtxca8KeRbmZ6JjwneFJrnHeXg9fm6f1EOx2/yawhdWuGg0HrIY3VAP2jvZHJi xhZljJ1QhmdSGH2/pYdWi7Lgv4ge151OSbZB7MZvwpZ5+WYI/JbDy1lTg7k/Gu93/n KDPpAhWTV+W7V1CGF/Mv2L78vOI3UYIjAbX8N/ng= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731203AbfA1QCE (ORCPT ); Mon, 28 Jan 2019 11:02:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:47274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731166AbfA1QCC (ORCPT ); Mon, 28 Jan 2019 11:02:02 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CFF721927; Mon, 28 Jan 2019 16:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548691321; bh=bfYfdsACu4/XDMdOLmpqe4guQy3fQQGA9ejQermmO4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FOUO1o4e6wvFceuLFbrGsbM+i7xPuv65Bz8xCHyHIW55GdJYHUfmllqySJ18sxdYN d2vqxuTZLak1kQG2VHYaQfX9GGM3fm/5BzSjIqYu0UWa+8ASI/E3EoQbgeOwPiV09C dOLxiuJqPOTOoiYVqxxkkR92MshVcNpxkj8mDU2w= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Gao Xiang , Greg Kroah-Hartman , Sasha Levin , linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org Subject: [PATCH AUTOSEL 4.19 058/258] staging: erofs: fix the definition of DBG_BUGON Date: Mon, 28 Jan 2019 10:56:04 -0500 Message-Id: <20190128155924.51521-58-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128155924.51521-1-sashal@kernel.org> References: <20190128155924.51521-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gao Xiang [ Upstream commit eef168789866514e5d4316f030131c9fe65b643f ] It's better not to positively BUG_ON the kernel, however developers need a way to locate issues as soon as possible. DBG_BUGON is introduced and it could only crash when EROFS_FS_DEBUG (EROFS developping feature) is on. It is helpful for developers to find and solve bugs quickly by eng builds. Previously, DBG_BUGON is defined as ((void)0) if EROFS_FS_DEBUG is off, but some unused variable warnings as follows could occur: drivers/staging/erofs/unzip_vle.c: In function `init_alway:': drivers/staging/erofs/unzip_vle.c:61:33: warning: unused variable `work' [-Wunused-variable] struct z_erofs_vle_work *const work = ^~~~ Fix it to #define DBG_BUGON(x) ((void)(x)). Reviewed-by: Chao Yu Signed-off-by: Gao Xiang Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/erofs/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/erofs/internal.h b/drivers/staging/erofs/internal.h index 367b39fe46e5..e6313c54e3ad 100644 --- a/drivers/staging/erofs/internal.h +++ b/drivers/staging/erofs/internal.h @@ -39,7 +39,7 @@ #define debugln(x, ...) ((void)0) #define dbg_might_sleep() ((void)0) -#define DBG_BUGON(...) ((void)0) +#define DBG_BUGON(x) ((void)(x)) #endif #ifdef CONFIG_EROFS_FAULT_INJECTION -- 2.19.1