From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 677EEC282CD for ; Mon, 28 Jan 2019 16:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37D182175B for ; Mon, 28 Jan 2019 16:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548692273; bh=1mCV3Hfr9q13WSRfS5vH/OML9cu/hkc5yLDUS2pNTr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sfmWqq/eHtYXLsBBVaP3Jz+WI9mf7Asik4oCqose2RVaFQ02Hjfx4mxTAL8iDxV5V A+nP6e3SoT9zdiTeM+yHR52N5udiyzyF/BIqpdtgvahY3qzV1eRlQJog21G8hniex7 EAYy1OkkEHXxkw0PzMDH4bTwbkfGbnIQ6Gipp/3o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387670AbfA1QRv (ORCPT ); Mon, 28 Jan 2019 11:17:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:51760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388262AbfA1QRk (ORCPT ); Mon, 28 Jan 2019 11:17:40 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6502B20879; Mon, 28 Jan 2019 16:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548692259; bh=1mCV3Hfr9q13WSRfS5vH/OML9cu/hkc5yLDUS2pNTr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J7zaGqn29EaVrHGOaMmX7mys7rAHoXnDhMqJg72h6Xf8N8iXdGNtbOHnp/btlP8tj EgxXvjuTVNTkQePGdt1jSTDZvJq4rzVkGe6gZAT+fR7nGq1Jsv5SurIY/1Wv/0CQeM ZLqqbJ3kQs3Qfjclq4E0/gjT8UvIeUV0/DO3/GpY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Konstantin Khorenko , Jeff Kirsher , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 130/170] i40e: define proper net_device::neigh_priv_len Date: Mon, 28 Jan 2019 11:11:20 -0500 Message-Id: <20190128161200.55107-130-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128161200.55107-1-sashal@kernel.org> References: <20190128161200.55107-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Konstantin Khorenko [ Upstream commit 31389b53b3e0b535867af9090a5d19ec64768d55 ] Out of bound read reported by KASan. i40iw_net_event() reads unconditionally 16 bytes from neigh->primary_key while the memory allocated for "neighbour" struct is evaluated in neigh_alloc() as tbl->entry_size + dev->neigh_priv_len where "dev" is a net_device. But the driver does not setup dev->neigh_priv_len and we read beyond the neigh entry allocated memory, so the patch in the next mail fixes this. Signed-off-by: Konstantin Khorenko Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 904b42becd45..5d47a51e74eb 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -9772,6 +9772,9 @@ static int i40e_config_netdev(struct i40e_vsi *vsi) ether_addr_copy(netdev->dev_addr, mac_addr); ether_addr_copy(netdev->perm_addr, mac_addr); + /* i40iw_net_event() reads 16 bytes from neigh->primary_key */ + netdev->neigh_priv_len = sizeof(u32) * 4; + netdev->priv_flags |= IFF_UNICAST_FLT; netdev->priv_flags |= IFF_SUPP_NOFCS; /* Setup netdev TC information */ -- 2.19.1