From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36361C282CD for ; Mon, 28 Jan 2019 16:13:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED48D2177E for ; Mon, 28 Jan 2019 16:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548692010; bh=XMCt/Am89DSH2OqT69hpegTGT7rZbwrgd6n7iSi0E8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fFyyy2r3/yLYwF85VazPc4svcBF0XZGUdcGt9Pt/CfjRHZ9RhCyfaLNzqqiv9CUpK 2TL81W5NoMtl9u3e9QQ3r5kBgL5ZMYe+3O8KGtdI0zskUWPlXY/TUGL6DXJLOdiU3U K+q6aIGh7k5Ho2eTQ2nItLxwDDvZrs+99sy4w1Wo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387426AbfA1QN2 (ORCPT ); Mon, 28 Jan 2019 11:13:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:42088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732495AbfA1QNY (ORCPT ); Mon, 28 Jan 2019 11:13:24 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 931652147A; Mon, 28 Jan 2019 16:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548692003; bh=XMCt/Am89DSH2OqT69hpegTGT7rZbwrgd6n7iSi0E8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G5ZcIfgFRyCQwgiqL3861EtJTWv7Ww9IVANO+cOQT96sqRQDwYgYNa5KCrQ6TU3ps ouWPRzJnba1e2dg0LyHnRd7th+/YF9s2V0UnZiBo0KBILQXl2lMAKOycuzkDH9c5zo BdDU1ml9HrKxwGXeM2KxSZLb2lOq7UPtf3sTe5bk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yangtao Li , Thierry Reding , Sasha Levin , linux-tegra@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 035/170] soc/tegra: Don't leak device tree node reference Date: Mon, 28 Jan 2019 11:09:45 -0500 Message-Id: <20190128161200.55107-35-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128161200.55107-1-sashal@kernel.org> References: <20190128161200.55107-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li [ Upstream commit 9eb40fa2cd2d1f6829e7b49bb22692f754b9cfe0 ] of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. soc_is_tegra() doesn't do that, so fix it. Signed-off-by: Yangtao Li Acked-by: Jon Hunter [treding: slightly rewrite to avoid inline comparison] Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/soc/tegra/common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c index cd8f41351add..7bfb154d6fa5 100644 --- a/drivers/soc/tegra/common.c +++ b/drivers/soc/tegra/common.c @@ -22,11 +22,15 @@ static const struct of_device_id tegra_machine_match[] = { bool soc_is_tegra(void) { + const struct of_device_id *match; struct device_node *root; root = of_find_node_by_path("/"); if (!root) return false; - return of_match_node(tegra_machine_match, root) != NULL; + match = of_match_node(tegra_machine_match, root); + of_node_put(root); + + return match != NULL; } -- 2.19.1