From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720ABC282C8 for ; Mon, 28 Jan 2019 17:04:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FC08214DA for ; Mon, 28 Jan 2019 17:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548695046; bh=+08kEivjaylPhdnINX7HlWd5cEEIcp0NmtPWMsCw8Ko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=G9FXBPZgCs4h9NsIVsBzvnEH68R698y4hkAINKAyBe94s3/6UHR9prwlWcUQxhQwo hB6lzC3dclaoiIJIR2/bwOOwLWqqLAbXUFl1SePPQ9lrD15CGcCZDDNDoOMHPK5wrT /I4ihxEAf7XxD50Saz6671SYAlaw4WgZdwvk6K7I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387979AbfA1REF (ORCPT ); Mon, 28 Jan 2019 12:04:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:42820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387519AbfA1QNx (ORCPT ); Mon, 28 Jan 2019 11:13:53 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CEE120855; Mon, 28 Jan 2019 16:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548692033; bh=+08kEivjaylPhdnINX7HlWd5cEEIcp0NmtPWMsCw8Ko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P4ckEbp6GguOLBvThvEeqUTTJLagD0NicXrD5ndITe3sd6qKDoDj4F6PnH+4Ndg8D htRhDlSUGO3ZTbRgZ9MnJgzzLbuEEgRwrjIm5wOI5Pg5ChGrkm/y1GnbzpCESyxgB0 ltUErqf9HDuC9H8Aj2w+VmtMmFDGozzsXKUozmYE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yunlei He , Jaegeuk Kim , Sasha Levin , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 4.14 045/170] f2fs: move dir data flush to write checkpoint process Date: Mon, 28 Jan 2019 11:09:55 -0500 Message-Id: <20190128161200.55107-45-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128161200.55107-1-sashal@kernel.org> References: <20190128161200.55107-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yunlei He [ Upstream commit b61ac5b720146c619c7cdf17eff2551b934399e5 ] This patch move dir data flush to write checkpoint process, by doing this, it may reduce some time for dir fsync. pre: -f2fs_do_sync_file enter -file_write_and_wait_range <- flush & wait -write_checkpoint -do_checkpoint <- wait all -f2fs_do_sync_file exit now: -f2fs_do_sync_file enter -write_checkpoint -block_operations <- flush dir & no wait -do_checkpoint <- wait all -f2fs_do_sync_file exit Signed-off-by: Yunlei He Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/file.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 7d3189f1941c..5f549bc4e097 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -205,6 +205,9 @@ static int f2fs_do_sync_file(struct file *file, loff_t start, loff_t end, trace_f2fs_sync_file_enter(inode); + if (S_ISDIR(inode->i_mode)) + goto go_write; + /* if fdatasync is triggered, let's do in-place-update */ if (datasync || get_dirty_pages(inode) <= SM_I(sbi)->min_fsync_blocks) set_inode_flag(inode, FI_NEED_IPU); -- 2.19.1