From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE50C282C8 for ; Mon, 28 Jan 2019 16:31:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 727CA20663 for ; Mon, 28 Jan 2019 16:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548693072; bh=7vmwSnSkoSBlPJpO4xiuEwisQFItDkXoMXOIAveCiZQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rbaRAzU5c+teKXhhcyCj83MyqApV1eGo4IqNQfS5qpT1CJQiLUVwpDjXZy6YnLRmF ealr/RcqyRDdTVzhqxt4HKVh/BTgCKzp1vSdIrIIY2CzQ8gseLnenPLdB+b3LnkGZf EPYPggBQYqYK1xZHpgQsfWg9VC79/Z/nyMqUc2NI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390384AbfA1Q1N (ORCPT ); Mon, 28 Jan 2019 11:27:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:37020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390358AbfA1Q1K (ORCPT ); Mon, 28 Jan 2019 11:27:10 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 976132171F; Mon, 28 Jan 2019 16:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548692829; bh=7vmwSnSkoSBlPJpO4xiuEwisQFItDkXoMXOIAveCiZQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=doMtwnE/L/E7BhYPadr66rdGa/L2ACXFA0D57pnc2G1581zcfl2AS/ZUfHTlU7Jao zhfFZIsPBQX+loUnw/QVHWiQpZ0Bw0SRW8lfY09P+xXxiyJ57lvDSQj692UVs5SGSw 46RKcQTkT3jUBho0G78BZxRt9YS0/JgKeLuwJ62g= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yangtao Li , "Rafael J . Wysocki" , Sasha Levin , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 3.18 28/61] cpuidle: big.LITTLE: fix refcount leak Date: Mon, 28 Jan 2019 11:25:50 -0500 Message-Id: <20190128162623.59854-28-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128162623.59854-1-sashal@kernel.org> References: <20190128162623.59854-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li [ Upstream commit 9456823c842f346c74265fcd98d008d87a7eb6f5 ] of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. Signed-off-by: Yangtao Li Acked-by: Daniel Lezcano Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpuidle/cpuidle-big_little.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c index fbc00a1d3c48..355dc3d9cb35 100644 --- a/drivers/cpuidle/cpuidle-big_little.c +++ b/drivers/cpuidle/cpuidle-big_little.c @@ -175,6 +175,7 @@ static int __init bl_idle_init(void) { int ret; struct device_node *root = of_find_node_by_path("/"); + const struct of_device_id *match_id; if (!root) return -ENODEV; @@ -182,7 +183,11 @@ static int __init bl_idle_init(void) /* * Initialize the driver just for a compliant set of machines */ - if (!of_match_node(compatible_machine_match, root)) + match_id = of_match_node(compatible_machine_match, root); + + of_node_put(root); + + if (!match_id) return -ENODEV; /* * For now the differentiation between little and big cores -- 2.19.1