From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D5CC282CD for ; Mon, 28 Jan 2019 16:30:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1BCC20663 for ; Mon, 28 Jan 2019 16:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548693043; bh=pp8ZcbXEYnNZYIEatdvnpMe04IUr2BN+1gcNZ2e4cAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=psvcNSY102r8u6N3WfwixzUGVNhebKv+0ZJr7SNsXVRFQHO1hXSy+NzRWEtpFAQ1G UU+VUHNBgb/iJi9fIsOvBdpRDQuXTAbSVvO6kasaon4BD58QuTz4jAJ131dC7sA+Ez ahPLVmOQDJHoYr+GJr+Ai3znYmwD4e1JJ3lk0jwM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390558AbfA1Qal (ORCPT ); Mon, 28 Jan 2019 11:30:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:37408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390404AbfA1Q1Y (ORCPT ); Mon, 28 Jan 2019 11:27:24 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 825722175B; Mon, 28 Jan 2019 16:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548692843; bh=pp8ZcbXEYnNZYIEatdvnpMe04IUr2BN+1gcNZ2e4cAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=peTkSaKcGI/DbOGXXXpjBz3pKSXh1wvKHA9fnIAcyG1KahxFMCAwU/PgrPB5OnC/x 1IExsq71DKyctdb3be7hxXHnVBqoqiIMGqylvXBHUw99BMngYjINuWudcFGwEWr8yq hJdAoGOYUlGCoyEd2sAMUzJk44KtWToTHRgv1h4M= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Beomho Seo , Marek Szyprowski , Greg Kroah-Hartman , Sasha Levin , linux-serial@vger.kernel.org Subject: [PATCH AUTOSEL 3.18 34/61] tty: serial: samsung: Properly set flags in autoCTS mode Date: Mon, 28 Jan 2019 11:25:56 -0500 Message-Id: <20190128162623.59854-34-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128162623.59854-1-sashal@kernel.org> References: <20190128162623.59854-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Beomho Seo [ Upstream commit 31e933645742ee6719d37573a27cce0761dcf92b ] Commit 391f93f2ec9f ("serial: core: Rework hw-assited flow control support") has changed the way the autoCTS mode is handled. According to that change, serial drivers which enable H/W autoCTS mode must set UPSTAT_AUTOCTS to prevent the serial core from inadvertently disabling TX. This patch adds proper handling of UPSTAT_AUTOCTS flag. Signed-off-by: Beomho Seo [mszyprow: rephrased commit message] Signed-off-by: Marek Szyprowski Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/samsung.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index 957992ceba0a..67cbc5647c36 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -817,11 +817,14 @@ static void s3c24xx_serial_set_termios(struct uart_port *port, wr_regl(port, S3C2410_ULCON, ulcon); wr_regl(port, S3C2410_UBRDIV, quot); + port->status &= ~UPSTAT_AUTOCTS; + umcon = rd_regl(port, S3C2410_UMCON); if (termios->c_cflag & CRTSCTS) { umcon |= S3C2410_UMCOM_AFC; /* Disable RTS when RX FIFO contains 63 bytes */ umcon &= ~S3C2412_UMCON_AFC_8; + port->status = UPSTAT_AUTOCTS; } else { umcon &= ~S3C2410_UMCOM_AFC; } -- 2.19.1