From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D70C282C8 for ; Mon, 28 Jan 2019 16:28:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B95920879 for ; Mon, 28 Jan 2019 16:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548692891; bh=CUhsIb/Rcezh3hqxk9oVOpXk6KMo5uI8+8fEERLhdw4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TNzIOaRZBOxdZWv6fR8i6jeJpTY3wfQ9/o0Uf1U89TSB5Tg70HO/+2THM5kf8TPdw Ax2tYmDxVzNcksTMcFMgXqHodxPAZzgVkHtvpKyPDXp+pgSX96ja8G1oUOspwYi388 5LQFEpjP5jXQdM+BCzWxIylTa2qi3DC2iKnH0d0A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390593AbfA1Q2J (ORCPT ); Mon, 28 Jan 2019 11:28:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:38648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390582AbfA1Q2H (ORCPT ); Mon, 28 Jan 2019 11:28:07 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75D7620879; Mon, 28 Jan 2019 16:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548692887; bh=CUhsIb/Rcezh3hqxk9oVOpXk6KMo5uI8+8fEERLhdw4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MCJLR1syChKPQ0ytfk5GXsC/2TvCGFQN7lZhjYRzf8FADaAN1EOJV/faSjm72f9jp TYi5bRPEQEphkoxDIxUOuye3t1ohcOhJiNSmCgFO2Rl8G3b3yqNSdhOj4KbZK5eACe X6xsdSDIGdc352LYlwA5795Gb0TBq2yvd72sawhQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wenwen Wang , Jens Axboe , Sasha Levin Subject: [PATCH AUTOSEL 3.18 57/61] gdrom: fix a memory leak bug Date: Mon, 28 Jan 2019 11:26:19 -0500 Message-Id: <20190128162623.59854-57-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128162623.59854-1-sashal@kernel.org> References: <20190128162623.59854-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang [ Upstream commit 093c48213ee37c3c3ff1cf5ac1aa2a9d8bc66017 ] In probe_gdrom(), the buffer pointed by 'gd.cd_info' is allocated through kzalloc() and is used to hold the information of the gdrom device. To register and unregister the device, the pointer 'gd.cd_info' is passed to the functions register_cdrom() and unregister_cdrom(), respectively. However, this buffer is not freed after it is used, which can cause a memory leak bug. This patch simply frees the buffer 'gd.cd_info' in exit_gdrom() to fix the above issue. Signed-off-by: Wenwen Wang Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/cdrom/gdrom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c index e2808fefbb78..1852d19d0d7b 100644 --- a/drivers/cdrom/gdrom.c +++ b/drivers/cdrom/gdrom.c @@ -882,6 +882,7 @@ static void __exit exit_gdrom(void) platform_device_unregister(pd); platform_driver_unregister(&gdrom_driver); kfree(gd.toc); + kfree(gd.cd_info); } module_init(init_gdrom); -- 2.19.1