From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF17C282C8 for ; Mon, 28 Jan 2019 19:30:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D453721741 for ; Mon, 28 Jan 2019 19:30:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NZcEj/Qa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727310AbfA1TaI (ORCPT ); Mon, 28 Jan 2019 14:30:08 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41160 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726862AbfA1TaF (ORCPT ); Mon, 28 Jan 2019 14:30:05 -0500 Received: by mail-pg1-f194.google.com with SMTP id m1so7632459pgq.8; Mon, 28 Jan 2019 11:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=gNih+kGXsY02yGlMFspxrtQWhmYIiMEFH/7OeSdZ1fM=; b=NZcEj/Qaa2hGJoUeXyh4r9timoiJ7QcNCGfKBZBp+gt7ZNs2tp/aNe8bcXTugXtCRj 6iMTv0Zdq7g23k+NE6dr0DA4213i+bg8B5hLxS/jeDEBOZ/kQgaL5GlUGPTfAvrjx9lf uo+gheZlU11FYVIto2rEvaJpFMzEh6N4+K9LLMVX6sN7U86ouyXSeOT6HJEtSbz7dpsP k5somAVoILwh1gBslPFkaXSOZLrh74pEXEvXu/Lqi0x9rXWQD94je3vqse/mOsWe191u 1eyuQZQwbeUs/W2krdQDSp1UnVBRg5TqpKspZu6y4FL2VB3dU8fef06o7h+aOKOjlpo/ yZKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=gNih+kGXsY02yGlMFspxrtQWhmYIiMEFH/7OeSdZ1fM=; b=YejsB0pz6YgxrO/Zg9DGwGIMJY9wPYMSpeXz9JOoM2jsdDshzEs8IIrvail7wN03gF osmp7dsZM/fcEmvtDzqGxtIPOfpu6J4/8y8nG/JudoPCqzguDlN4DuHmxstVhvoIwyhx i3+aURjryo7JIrx3mmstj3j++siLgyci/MFo7iccMYNibKlRJ7pmK3vORCkrdwfuFVP4 Ho5Lxqg93kb+DJnLF6nBevtL+hlunN8RsBhodu4IN7L01SDYd3+lfUgwbah8EAnmcwvk Dkrg90+aDfvoFGngr/RYW5r4dVcdaPkM+imo9VbVoEC+1UThKgJCiaS6aAOQLYWte5BM PdTQ== X-Gm-Message-State: AJcUukfYrZ2kwqgfTS3GD3dkTvlvi143MJ/BuF6obUGWyMmilv0jVsWI sGCSYD2TEfZGxQYvK2huuqPzRXwv X-Google-Smtp-Source: ALg8bN4DeTvski8L5NJ175au0AKTV/AlxG1vWWZQVzCXdCqK1rohZwW/5YLgkVEeNUh9KIthj4q2TQ== X-Received: by 2002:a62:2606:: with SMTP id m6mr22549508pfm.133.1548703804786; Mon, 28 Jan 2019 11:30:04 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id b7sm45385896pfa.52.2019.01.28.11.30.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jan 2019 11:30:04 -0800 (PST) Date: Mon, 28 Jan 2019 11:30:02 -0800 From: Dmitry Torokhov To: Jonathan Bakker Cc: =?utf-8?B?UGF3ZcWC?= Chmiel , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mchehab+samsung@kernel.org" , "colyli@suse.de" , "ckeepax@opensource.wolfsonmicro.com" , "andrew.smirnov@gmail.com" , "arnd@arndb.de" , "xiaotong.lu@spreadtrum.com" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 4/4] dt-bindings: input: Add documentation for gp2a sensor Message-ID: <20190128193002.GE34692@dtor-ws> References: <20190125175045.22576-1-pawel.mikolaj.chmiel@gmail.com> <20190125175045.22576-5-pawel.mikolaj.chmiel@gmail.com> <20190126013237.GF212026@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 26, 2019 at 03:14:14AM +0000, Jonathan Bakker wrote: > Hi Dmitry, > > Thanks for your review of the patches. > > Considering that the light sensor part should be in IIO, should the entire driver be rewritten as an IIO driver? There's already the driver for gp2ap020a00f there which is presumably the gp2ap002a00f's successor and does the same functions. I'd be fine with that. > > On 2019-01-25 5:32 p.m., Dmitry Torokhov wrote: > > On Fri, Jan 25, 2019 at 06:50:45PM +0100, Paweł Chmiel wrote: > >> From: Jonathan Bakker > >> > >> This commit adds documentation for Sharp GP2AP002A00F. > >> It's Proximity/Opto Sensor connected over i2c. > >> > >> Signed-off-by: Jonathan Bakker > >> Signed-off-by: Paweł Chmiel > >> --- > >> .../bindings/input/sharp,gp2ap002a00f.txt | 29 +++++++++++++++++++ > >> 1 file changed, 29 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/input/sharp,gp2ap002a00f.txt > >> > >> diff --git a/Documentation/devicetree/bindings/input/sharp,gp2ap002a00f.txt b/Documentation/devicetree/bindings/input/sharp,gp2ap002a00f.txt > >> new file mode 100644 > >> index 000000000000..c524eb7d3d60 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/input/sharp,gp2ap002a00f.txt > >> @@ -0,0 +1,29 @@ > >> +* Sharp GP2AP002A00F I2C Proximity/Opto Sensor > >> + > >> +Required properties: > >> +- compatible : Should be "sharp,gp2ap002a00f" > >> +- reg : The I2C address of the sensor > >> +- vout-gpio : The gpio connected to the vout pin > > > > Do you know what it is for? > > > It's the control of the main power supply to the chip. In this case it should be a power supply (regulator), not gpio. Thanks. -- Dmitry