From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator
Date: Tue, 29 Jan 2019 10:01:46 +0100 [thread overview]
Message-ID: <20190129090146.GD4344@kernel.org> (raw)
In-Reply-To: <20190123083338.GK27625@krava>
Em Wed, Jan 23, 2019 at 09:33:38AM +0100, Jiri Olsa escreveu:
> On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote:
> > Notice that the use of the bitwise OR operator '|' always leads to
> > true in this particular case, which seems a bit suspicious due to
> > the context in which this expression is being used.
> >
> > Fix this by using bitwise AND operator '&' instead.
> >
> > This bug was detected with the help of Coccinelle.
> >
> > Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> nice catch
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Argh, applied, and looking for an old brown paper bag...
- Arnaldo
next prev parent reply other threads:[~2019-01-29 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 23:34 [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator Gustavo A. R. Silva
2019-01-23 8:33 ` Jiri Olsa
2019-01-23 8:40 ` Gustavo A. R. Silva
2019-01-28 19:29 ` Gustavo A. R. Silva
2019-01-29 9:01 ` Arnaldo Carvalho de Melo [this message]
2019-02-09 12:19 ` [tip:perf/urgent] perf tests " tip-bot for Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129090146.GD4344@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=gustavo@embeddedor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox