From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73334C169C4 for ; Tue, 29 Jan 2019 10:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CF0620881 for ; Tue, 29 Jan 2019 10:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548759222; bh=joVLrl1zlqUft3+smOkYEck6wN/8HpVKRp3tcVsDB9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LyFzQCmt40CJNN/yENFbyqMmh7JyiqWHgp/vmGc36ZHDwJbkfKvNk9T2qGtTQH5Eu 9aUfSRDtJAnqHZzkT70CAbM33EuxNlM0/UfoRMvm2NUqvYy/ONT12kRDH4rXLhMjPA 2ivN2yEW4Z2JLjYGBIeHTVlrezchjj5Fo0R1Midw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbfA2Kxk (ORCPT ); Tue, 29 Jan 2019 05:53:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:38924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725927AbfA2Kxk (ORCPT ); Tue, 29 Jan 2019 05:53:40 -0500 Received: from quaco.ghostprotocols.net (ovpn-brq.redhat.com [213.175.37.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BE8920881; Tue, 29 Jan 2019 10:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548759219; bh=joVLrl1zlqUft3+smOkYEck6wN/8HpVKRp3tcVsDB9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m2t5AuNeP7rKAMcawFt5Tg6o2KBg3SigWpTTVh+gecLRLcVlfnd1SEra1xo3W10gA G80qJYwxoYvtWgRsUAFKP/TuTyu6KYovlArPTZu2hVdyW74uTUlL9cGfwXfRk7gUwD m4HvnMjSEkAUMB6I1GG2aDFZoPYIIS+sLKTQZmjc= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id B25B44034F; Tue, 29 Jan 2019 11:53:37 +0100 (CET) Date: Tue, 29 Jan 2019 11:53:37 +0100 From: Arnaldo Carvalho de Melo To: Alexey Budankov Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , Namhyung Kim , Alexander Shishkin , Andi Kleen , linux-kernel Subject: Re: [PATCH v2 0/4] perf: enable compression of record mode trace to save storage space Message-ID: <20190129105337.GA17762@kernel.org> References: <20190129104543.GJ4344@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129104543.GJ4344@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jan 29, 2019 at 11:45:43AM +0100, Arnaldo Carvalho de Melo escreveu: > Em Mon, Jan 28, 2019 at 09:40:28AM +0300, Alexey Budankov escreveu: > > The patch set implements runtime trace compression for record mode and > > trace file decompression for report mode. Zstandard API [1] is used for > > compression/decompression of data that come from perf_events kernel > > Interesting, wasn't aware of this zstd library, I wonder if we can add > it and switch the other compression libraries we link against, so that > we're not adding one more library to the dep list of perf but removing > some instead, do you think this would be possible? > > $ ldd ~/bin/perf | wc -l > 30 > $ ldd ~/bin/perf | grep z > liblzma.so.5 => /lib64/liblzma.so.5 (0x00007f3dcc356000) > libz.so.1 => /lib64/libz.so.1 (0x00007f3dcb2aa000) > libbz2.so.1 => /lib64/libbz2.so.1 (0x00007f3dcb218000) > $ > > Humm, from the github page it says: > > ----- > The project is provided as an open-source dual BSD and GPLv2 licensed C > library, and a command line utility producing and decoding .zst, .gz, > .xz and .lz4 files. Should your project require another programming > language, a list of known ports and bindings is provided on Zstandard > homepage. > ----- > > So it would cover just liblzma and libz, right? Nevermind; [acme@quaco perf]$ zstdcat ~/git/perf/perf-5.0.0-rc2.tar.xz zstd: /home/acme/git/perf/perf-5.0.0-rc2.tar.xz: xz/lzma file cannot be uncompressed (zstd compiled without HAVE_LZMA) -- ignored So it handles those formats, _if_ linked with those libraries, duh. - Arnaldo