From: Sam Ravnborg <sam@ravnborg.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Michael Trimarchi <michael@amarulasolutions.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-amarula@amarulasolutions.com
Subject: Re: [PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel
Date: Tue, 29 Jan 2019 16:19:16 +0100 [thread overview]
Message-ID: <20190129151916.GA12635@ravnborg.org> (raw)
In-Reply-To: <CAMty3ZCejdo+ztipg0F0SSpSRZwxKxTbhbXA93YqM2GFozxFqg@mail.gmail.com>
Hi Jagan.
> >
> > I see DRM_MODE_ARG as mode argument, that print all mode timings but
> > here we need only 3 timings out of it. do we really need? if yes
> > please suggest an example.
>
> fyi: sent v6 for this except this change. Let me know if you have any
> comments on this.
Drivers looks fine, the above was just a quick suggestion to use some
exising plumbing.
You have done a nice job following up on all the feedback.
Sam
next prev parent reply other threads:[~2019-01-29 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 19:22 [PATCH v5 1/2] dt-bindings: panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel Jagan Teki
2019-01-25 19:22 ` [PATCH v5 2/2] drm/panel: " Jagan Teki
2019-01-25 19:52 ` Sam Ravnborg
2019-01-27 19:11 ` Jagan Teki
2019-01-29 15:06 ` Jagan Teki
2019-01-29 15:19 ` Sam Ravnborg [this message]
2019-01-30 12:55 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129151916.GA12635@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox