From: Andi Kleen <ak@linux.intel.com>
To: William Cohen <wcohen@redhat.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org
Subject: Re: [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX
Date: Tue, 29 Jan 2019 09:23:48 -0800 [thread overview]
Message-ID: <20190129172348.GS6118@tassilo.jf.intel.com> (raw)
In-Reply-To: <20190129170536.22510-1-wcohen@redhat.com>
On Tue, Jan 29, 2019 at 12:05:36PM -0500, William Cohen wrote:
> Fix incorrect event names for the Load_Miss_Real_Latency metric for
> Cascadelake server in the same manner as commit 91b2b97025 for SKL/SKX.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
>
> Signed-off-by: William Cohen <wcohen@redhat.com>
> ---
> tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> index 36c903faed0b..71e9737f4614 100644
> --- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> @@ -73,7 +73,7 @@
> },
> {
> "BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
> - "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
> + "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
> "MetricGroup": "Memory_Bound;Memory_Lat",
> "MetricName": "Load_Miss_Real_Latency"
> },
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-01-29 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 17:05 [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX William Cohen
2019-01-29 17:23 ` Andi Kleen [this message]
2019-02-05 17:19 ` Arnaldo Carvalho de Melo
2019-02-09 12:56 ` [tip:perf/core] " tip-bot for William Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129172348.GS6118@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wcohen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox