* [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX
@ 2019-01-29 17:05 William Cohen
2019-01-29 17:23 ` Andi Kleen
2019-02-09 12:56 ` [tip:perf/core] " tip-bot for William Cohen
0 siblings, 2 replies; 4+ messages in thread
From: William Cohen @ 2019-01-29 17:05 UTC (permalink / raw)
To: peterz, mingo, acme, linux-kernel
Cc: alexander.shishkin, jolsa, namhyung, ak, William Cohen
Fix incorrect event names for the Load_Miss_Real_Latency metric for
Cascadelake server in the same manner as commit 91b2b97025 for SKL/SKX.
Signed-off-by: William Cohen <wcohen@redhat.com>
---
tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
index 36c903faed0b..71e9737f4614 100644
--- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
+++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
@@ -73,7 +73,7 @@
},
{
"BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
- "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
+ "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
"MetricGroup": "Memory_Bound;Memory_Lat",
"MetricName": "Load_Miss_Real_Latency"
},
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX
2019-01-29 17:05 [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX William Cohen
@ 2019-01-29 17:23 ` Andi Kleen
2019-02-05 17:19 ` Arnaldo Carvalho de Melo
2019-02-09 12:56 ` [tip:perf/core] " tip-bot for William Cohen
1 sibling, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2019-01-29 17:23 UTC (permalink / raw)
To: William Cohen
Cc: peterz, mingo, acme, linux-kernel, alexander.shishkin, jolsa,
namhyung
On Tue, Jan 29, 2019 at 12:05:36PM -0500, William Cohen wrote:
> Fix incorrect event names for the Load_Miss_Real_Latency metric for
> Cascadelake server in the same manner as commit 91b2b97025 for SKL/SKX.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
>
> Signed-off-by: William Cohen <wcohen@redhat.com>
> ---
> tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> index 36c903faed0b..71e9737f4614 100644
> --- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> @@ -73,7 +73,7 @@
> },
> {
> "BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
> - "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
> + "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
> "MetricGroup": "Memory_Bound;Memory_Lat",
> "MetricName": "Load_Miss_Real_Latency"
> },
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX
2019-01-29 17:23 ` Andi Kleen
@ 2019-02-05 17:19 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-02-05 17:19 UTC (permalink / raw)
To: Andi Kleen
Cc: William Cohen, peterz, mingo, linux-kernel, alexander.shishkin,
jolsa, namhyung
Em Tue, Jan 29, 2019 at 09:23:48AM -0800, Andi Kleen escreveu:
> On Tue, Jan 29, 2019 at 12:05:36PM -0500, William Cohen wrote:
> > Fix incorrect event names for the Load_Miss_Real_Latency metric for
> > Cascadelake server in the same manner as commit 91b2b97025 for SKL/SKX.
>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
Thanks, applied.
- Arnaldo
> >
> > Signed-off-by: William Cohen <wcohen@redhat.com>
> > ---
> > tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> > index 36c903faed0b..71e9737f4614 100644
> > --- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> > +++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> > @@ -73,7 +73,7 @@
> > },
> > {
> > "BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
> > - "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
> > + "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
> > "MetricGroup": "Memory_Bound;Memory_Lat",
> > "MetricName": "Load_Miss_Real_Latency"
> > },
> > --
> > 2.20.1
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/core] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX
2019-01-29 17:05 [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX William Cohen
2019-01-29 17:23 ` Andi Kleen
@ 2019-02-09 12:56 ` tip-bot for William Cohen
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for William Cohen @ 2019-02-09 12:56 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, ak, acme, jolsa, hpa, tglx, peterz, mingo, namhyung,
wcohen, alexander.shishkin
Commit-ID: 2d08f87fe7a2e4d74dc8b0eb645737d83dd932a9
Gitweb: https://git.kernel.org/tip/2d08f87fe7a2e4d74dc8b0eb645737d83dd932a9
Author: William Cohen <wcohen@redhat.com>
AuthorDate: Tue, 29 Jan 2019 12:05:36 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 6 Feb 2019 10:00:40 -0300
perf vendor events intel: Fix Load_Miss_Real_Latency on CLX
Fix incorrect event names for the Load_Miss_Real_Latency metric for
Cascadelake server in the same manner as commit 91b2b97025 for SKL/SKX.
Signed-off-by: William Cohen <wcohen@redhat.com>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20190129170536.22510-1-wcohen@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
index 36c903faed0b..71e9737f4614 100644
--- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
+++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
@@ -73,7 +73,7 @@
},
{
"BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
- "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
+ "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
"MetricGroup": "Memory_Bound;Memory_Lat",
"MetricName": "Load_Miss_Real_Latency"
},
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-09 12:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-29 17:05 [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX William Cohen
2019-01-29 17:23 ` Andi Kleen
2019-02-05 17:19 ` Arnaldo Carvalho de Melo
2019-02-09 12:56 ` [tip:perf/core] " tip-bot for William Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox