From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Tejun Heo <tj@kernel.org>,
Sargun Dhillon <sargun@sargun.me>
Subject: Re: [PATCH v2] sched/fair: Fix insertion in rq->leaf_cfs_rq_list
Date: Wed, 30 Jan 2019 17:58:59 +0100 [thread overview]
Message-ID: <20190130165859.GE2296@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKfTPtC1vRrvSH=JdQjOfeh809gRiwKGE7373zaF9jT862C1+g@mail.gmail.com>
On Wed, Jan 30, 2019 at 04:48:47PM +0100, Vincent Guittot wrote:
> On Wed, 30 Jan 2019 at 14:40, Peter Zijlstra <peterz@infradead.org> wrote:
> >
>
> >
> > static inline void list_del_leaf_cfs_rq(struct cfs_rq *cfs_rq)
> > @@ -352,7 +354,12 @@ static inline void list_del_leaf_cfs_rq(struct cfs_rq *cfs_rq)
> > }
> > }
> >
> > -/* Iterate through all leaf cfs_rq's on a runqueue: */
> > +static inline void assert_list_leaf_cfs_rq(struct rq *rq)
> > +{
> > + SCHED_WARN_ON(rq->tmp_alone_branch != &rq->lead_cfs_rq_list);
>
> small typo : s/lead_cfs_rq_list/leaf_cfs_rq_list/
D'0h, thanks!
next prev parent reply other threads:[~2019-01-30 16:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 17:18 [PATCH] sched/fair: Fix insertion in rq->leaf_cfs_rq_list Vincent Guittot
2019-01-30 5:22 ` [PATCH v2] " Vincent Guittot
2019-01-30 13:04 ` Peter Zijlstra
2019-01-30 13:06 ` Peter Zijlstra
2019-01-30 13:27 ` Peter Zijlstra
2019-01-30 13:29 ` Vincent Guittot
2019-01-30 13:40 ` Peter Zijlstra
2019-01-30 15:48 ` Vincent Guittot
2019-01-30 16:58 ` Peter Zijlstra [this message]
2019-01-30 14:01 ` Peter Zijlstra
2019-01-30 14:01 ` Peter Zijlstra
2019-01-30 14:27 ` Vincent Guittot
2019-01-30 17:40 ` Vincent Guittot
2019-01-30 14:30 ` Vincent Guittot
2019-02-04 9:03 ` [tip:sched/core] " tip-bot for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130165859.GE2296@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sargun@sargun.me \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox