Re: [RFC PATCH v3 06/10] devicetree: bindings: Document first ROHM BD70528 bindings

Matti Vaittinen
2019-01-31T06:41:00Z

Hello Rob,

Thanks for taking the carefull look once again =)

On Wed, Jan 30, 2019 at 12:53:44PM -0600, Rob Herring wrote:
> On Wed, Jan 30, 2019 at 11:09:55AM +0200, Matti Vaittinen wrote:
> > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
> > drivers) and 4 GPIO pins which can be configured for I/O or
> > as interrupt sources withe configurable trigger levels.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > .../devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 104 +++++++++++++++++++++

snip

> > + - interrupt-parent : Phandle to the parent interrupt controller.
>
> Don't document this. It is implied and could be in a parent node.

Allright. I'll remove this then.

> > + - clock-frequency : Should be 32768
>
> Forget to drop this?

Well spotted. The rate should come from parent clock. I'll drop this
too.

> > +Example:
> > +/* external oscillator */
> > +osc: oscillator {
> > + compatible = "fixed-clock";
> > + #clock-cells = <1>;
> > + clock-frequency = <32768>;
> > + clock-output-names = "osc";
> > +};
> > +
> > +pmic: bd70528@4b {
>
> pmic@4b
>
> Node names should be generic.

Ok. I will change this.

Br,
Matti

--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC